fix (#3826): In DropdownMenu, allow Tab navigation to interactive elements w…#3833
Open
ahmadaurwahaj wants to merge 3 commits intoradix-ui:mainfrom
Open
fix (#3826): In DropdownMenu, allow Tab navigation to interactive elements w…#3833ahmadaurwahaj wants to merge 3 commits intoradix-ui:mainfrom
ahmadaurwahaj wants to merge 3 commits intoradix-ui:mainfrom
Conversation
…thin menu content
🦋 Changeset detectedLatest commit: 2d3d6e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…thin menu content
…set to patch for react menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3826 - Dropdown Footer Accessibility Concern
Description
Currently, pressing Tab anywhere inside a DropdownMenu immediately closes it via
event.preventDefault(). This means keyboard users cannot reach interactive elements placed inside the menu content that are outside ofDropdownMenu.Item- such as footer buttons ("Apply", "Create New", "Save", etc.).This is a real accessibility gap: it is a common pattern to put action buttons at the bottom of a dropdown panel, and those buttons are completely unreachable by keyboard.
Changes:
event.preventDefault()on Tab inMenuContentImpl'sonKeyDownhandler with smart Tab navigation logic.getTabbableCandidates()utility usingTreeWalkerto enumerate focusable elements within the content container.WithFooterActionsStorybook story to demonstrate the fix.How to test manually:
pnpm --filter storybook dev