fix(slider): onValueCommit not called when range narrows to single value#3832
Open
buyuan-dev wants to merge 1 commit intoradix-ui:mainfrom
Open
fix(slider): onValueCommit not called when range narrows to single value#3832buyuan-dev wants to merge 1 commit intoradix-ui:mainfrom
buyuan-dev wants to merge 1 commit intoradix-ui:mainfrom
Conversation
Fixes radix-ui#3698 When dragging a range slider thumb to overlap another (e.g. [105, 107] → [105, 105]), onValueCommit was never fired because handleSlideEnd compared individual thumb values using valueIndexToChangeRef.current, but indexOf returns 0 for both thumbs when they overlap. The fix compares the full value arrays using String(values) !== String(prevValues), matching the approach already used in updateValues.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where onValueCommit was not fired when dragging a range slider thumb to overlap another.
Problem
When dragging the right thumb of a range slider to overlap the left thumb (e.g. [105, 107] ? [105, 105]), onValueCommit was never fired.
Root Cause
handleSlideEnd compared individual thumb values using �alueIndexToChangeRef.current as the index. However, when two thumbs land on the same value, indexOf returns � for both, causing the comparison to check the left thumb against itself.
Fix
Changed handleSlideEnd to compare the full value arrays using String(values) !== String(prevValues), matching the approach already used in updateValues.
Testing
Fixes #3698
Fixes #3829