chore/sync resource types contrib - #12462
Closed
willdavsmith wants to merge 1 commit into
Closed
Conversation
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
|
This PR requires exactly 1 of the following labels: pr:standard, pr:important. Label descriptions:
@willdavsmith, please add the appropriate label to this PR before merging. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs the repo’s pinned resource-types-contrib snapshot and refreshes the built-in provider manifests to match the newer “managed Radius.Security/secrets” pattern (secret outputs are no longer surfaced/injected as plain connection env vars). Also brings in the containerImages icon SVG so the built-in type set stays complete.
Changes:
- Bump
github.com/radius-project/resource-types-contribto a newer pseudo-version ingo.mod/go.sum. - Update several built-in provider manifests (dev + self-hosted) to replace plaintext secret output properties with a
properties.secretsblock (managed secret reference + declared secret keys). - Add
containerImages.svgicon assets for dev + self-hosted manifests.
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Update pinned resource-types-contrib pseudo-version. |
| go.sum | Update module hashes for the new resource-types-contrib version. |
| deploy/manifest/built-in-providers/self-hosted/search.yaml | Switch API key output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/redisCaches.yaml | Switch URL secret output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/rabbitMQ.yaml | Switch connection string secret output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/objectStorage.yaml | Switch connectionString/accountKey outputs to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/mongoDatabases.yaml | Switch connection string secret output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/models.yaml | Switch API key output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/kafka.yaml | Switch connection string secret output to managed secret reference under properties.secrets + update docs. |
| deploy/manifest/built-in-providers/self-hosted/containerImages.svg | Add icon SVG for the containerImages resource type. |
| deploy/manifest/built-in-providers/dev/search.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/redisCaches.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/rabbitMQ.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/objectStorage.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/mongoDatabases.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/models.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/kafka.yaml | Same as self-hosted: managed secret reference under properties.secrets + docs. |
| deploy/manifest/built-in-providers/dev/containerImages.svg | Add icon SVG for the containerImages resource type. |
Comment on lines
+51
to
+54
| The `url` secret is NOT injected via the connection — it is materialized into | ||
| a managed `Radius.Security/secrets` resource. Bind it into a container env var | ||
| with a `secretKeyRef`, using `redis.properties.secrets.name` as the `secretName` | ||
| and key `url` (see the `secrets` property). |
Comment on lines
+51
to
+54
| The `url` secret is NOT injected via the connection — it is materialized into | ||
| a managed `Radius.Security/secrets` resource. Bind it into a container env var | ||
| with a `secretKeyRef`, using `redis.properties.secrets.name` as the `secretName` | ||
| and key `url` (see the `secrets` property). |
Comment on lines
+49
to
+52
| The `connectionString` secret is NOT injected via the connection — it is | ||
| materialized into a managed `Radius.Security/secrets` resource. Bind it into | ||
| a container env var with a `secretKeyRef`, using `mongo.properties.secrets.name` | ||
| as the `secretName` and key `connectionString` (see the `secrets` property). |
Comment on lines
+49
to
+52
| The `connectionString` secret is NOT injected via the connection — it is | ||
| materialized into a managed `Radius.Security/secrets` resource. Bind it into | ||
| a container env var with a `secretKeyRef`, using `mongo.properties.secrets.name` | ||
| as the `secretName` and key `connectionString` (see the `secrets` property). |
Comment on lines
+33
to
+36
| The `connectionString` secret is NOT injected via the connection — it is | ||
| materialized into a managed `Radius.Security/secrets` resource. Bind it into | ||
| a container env var with a `secretKeyRef`, using `rabbitmq.properties.secrets.name` | ||
| as the `secretName` and key `connectionString` (see the `secrets` property). |
Comment on lines
+33
to
+36
| The `connectionString` secret is NOT injected via the connection — it is | ||
| materialized into a managed `Radius.Security/secrets` resource. Bind it into | ||
| a container env var with a `secretKeyRef`, using `rabbitmq.properties.secrets.name` | ||
| as the `secretName` and key `connectionString` (see the `secrets` property). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12462 +/- ##
==========================================
- Coverage 53.53% 53.51% -0.02%
==========================================
Files 758 758
Lines 49326 49326
==========================================
- Hits 26405 26397 -8
- Misses 20476 20480 +4
- Partials 2445 2449 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rad upgrade kubernetes(rad upgrade kubernetesdoes not reuse existing Helm release values (resets to chart defaults) #11218) (Preserve Helm release values onrad upgrade kubernetes(#11218) #12029)defaults.yamlto include new types (Updatedefaults.yamlto include new types #12332)rad env updto work withRADIUS_PREVIEWenv variable (Updrad env updto work withRADIUS_PREVIEWenv variable #12371)Summary
Reason for change
Fixes #
How to test
File change summary