Repository navigation
Cleanup guard: no flipped negations, "yes" pastes, numbers and vocabulary fixes accepted - #16
Merged
Merged
Conversation
…as asides
The cleanup model answers <aside> for a one-word reply, and a short aside
was always believed, so nothing was pasted. A dictation of one or two
reply words (yes, ok, okay, yeah, thank you, ...) is never an aside now:
it goes in as a sentence ("Yes."). "hmm let me think" is still left out.
…else changed
"the test is not passing" -> "The test is passing." and "do not merge
this" -> "Merge this." passed the guard, because fewer than three words
were dropped. A dropped not/no/never/don't/can't/without/... now counts on
its own, unless what it negated went with it ("it's not good, it's
great" -> "It's great."), it was said twice, or "no" takes back what
came before it ("at three, no, four" -> "at four"). A negation the
speaker never said is caught the same way.
…, 404, 9:30)
The guard only knew simple number words, so correct formatting was
thrown away for the raw transcript: "one hundred twenty" -> 120 counted
as three dropped words, and 2.5, 2026, 31st and 404 as made up. The
spoken-number check now also reads "and" after a scale, decimals ("two
point five"), words read out in a row ("twenty twenty six", "four oh
four", phone numbers), ordinals, "one and a half" and clock times
("half past nine", "quarter to nine", "nine o'clock"), and remembers
which words each reading stands for, so number words the cleanup wrote
as digits aren't counted as dropped (and the ones it didn't still are:
"five five five one two three four" -> 5:55 is caught). Thousands
separators and "st/nd/rd/th" are ignored. Runs are capped at 20 words
and the sums saturate.
"send it to jay at example dot com" -> "Send it to jay@example.com." was flagged as dropping "example dot com": everything after an @ was taken for a file reference and left out of the comparison. The @ of an email address now counts as the "at" that was said, and symbols said as words (dot, slash, colon, dash, ...) aren't counted as dropped.
The faithfulness guard never looked at words.txt, so with 'Kubernetes:
often heard as "cube and eighties"' in it, "deploy it to cube and
eighties tonight" -> "Deploy it to Kubernetes tonight." was flagged as
adding "kubernetes" and the transcript was pasted as heard. The guard
now gets the vocabulary: a term's words are explained where one of the
ways it's misheard was said, or the term itself spelled or spaced
another way ("next JS" -> Next.js), and the misheard words aren't
counted as dropped. Being in the vocabulary isn't enough on its own:
the model writes its terms where nothing like them was said ("slash got
shaders skill" -> "Claude Code"), and that is still caught.
…some word said
explained() took any new word 60% like any word of the transcript, or
sharing its first four letters, so "Dictation" -> "Diction" passed, and
"Py script" -> "Python script" because of a "then" elsewhere in the
dictation (and "computer" -> "company"). A new word is now explained by:
the word itself or another form of it (ship / shipping / shipped, by its
ending) anywhere in what was said; and only next to where it was
written, the same word a letter apart (colour / color, there / their; a
short word may only gain or lose one, so "test" isn't "text"), words
said apart or run together ("post gress" -> Postgres, "nextjs" ->
Next.js), casual speech written out ("gonna" -> going to), a word that
sounds the same (their / they're), or a vocabulary term. "Claw" ->
Claude now rests on words.txt saying so, which it does.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
… no 6, "one second" no 3, "ninety nine point nine" no 9.9, "five oh and" no 50)
…"I dont know" -> "I don't know.")
… it's fine"), unless it's none of something
…ess the speaker took it back
…the term misheard ("cloud" -> Claude)
…ot mean" -> "means" drops the negation)
Owner
Author
|
Review fixes (independent review, since CodeRabbit is at its limit), 11 commits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the local cleanup's faithfulness guard (
crates/core/src/cleanup.rs), from testing master after #11. Built on #12; its two xtask commits drop out of this diff once #12 merges. The Claude Haiku path is untouched.localflow --eval: 32/41 before and after, identical per-case verdicts.cargo test --workspace: 106 passed. Clippy clean.