-
Notifications
You must be signed in to change notification settings - Fork 4k
Show oldest stream message timestamp in management UI #15412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,10 @@ | |
| <th>Segments</th> | ||
| <td><%= fmt_string(queue.segments) %></td> | ||
| </tr> | ||
| <tr> | ||
| <th>Oldest message</th> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Oldest message" ? "First timestamp" ? I'm not attached to the phrasing here
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Oldest" is unambiguous while "first" can be interpreted as the head or the tail, so I'd use "oldest" personally. |
||
| <td><%= fmt_timestamp_mini(queue.first_timestamp) %></td> | ||
| </tr> | ||
| </table> | ||
|
|
||
| <table class="facts"> | ||
|
|
@@ -53,4 +57,4 @@ | |
| </th> | ||
| <td class="r"><%= fmt_bytes(queue.memory) %></td> | ||
| </tr> | ||
| </table> | ||
| </table> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes show the dimmed "?" when the page is waiting for data to arrive. Otherwise these fmts would show "NaN-NaN-NaN"