-
Notifications
You must be signed in to change notification settings - Fork 4
Add "bedtools map" with a new group_by logic #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mrvollger
wants to merge
5
commits into
quinlan-lab:main
Choose a base branch
from
mrvollger:groupmap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
64357ce
add build.rs to embed Python library rpath for runtime linking
c93317c
Add map subcommand for aggregating overlapping B values per A interval
3cb25d5
Address PR review: compute signature, name-match bug, error handling,…
dcbf9ee
Move map integration tests to tests/integration_map.rs
b60954f
Fix edge cases: name-match with missing names, column validation, non…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| fn main() { | ||
| // Use pyo3-build-config to get the Python interpreter's configuration, | ||
| // then emit an rpath so the test/binary can find libpython at runtime on macOS. | ||
| let config = pyo3_build_config::get(); | ||
| if let Some(lib_dir) = &config.lib_dir { | ||
| println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_dir); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build script emits
cargo:rustc-link-arg=-Wl,-rpath,...for every target wheneverlib_diris present, but that linker syntax is not portable (notably MSVC/Windows), so cross-platform builds can fail at link time even though this rpath workaround is only needed on macOS. Add an explicit target check (for example macOS-only, or at least non-MSVC) before printing this flag.Useful? React with 👍 / 👎.