Optimize stale key iteration when digest is up to date#189
Open
Stool233 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73.
What
This updates
NodeState::stale_key_valuesto return an empty iterator immediately whenfloor_versionis greater than or equal to the node state'smax_version.Why
No key-value in a
NodeStatecan have a version greater thanmax_version, so whenfloor_version >= max_version, there cannot be any stale key-value withversion > floor_version.The main delta computation path already skips nodes whose
max_versionis not greater than the digest'smax_versionbefore calling this helper. This change applies the same fast path insideNodeState::stale_key_valuesitself, removes the existing TODO, and keeps the helper efficient for direct or future call sites.This does not change the public API, gossip semantics, delta contents, or wire format.
Validation
cargo test -p chitchat --lib stale_key_valuescargo test -p chitchat test_sorted_stale_nodes_offercargo test -p chitchat --lib