Skip to content

ci: fix bazel test suite - #3078

Open
benfdking wants to merge 1 commit into
mainfrom
agent/fix-bazel-test-suite
Open

ci: fix bazel test suite#3078
benfdking wants to merge 1 commit into
mainfrom
agent/fix-bazel-test-suite

Conversation

@benfdking

Copy link
Copy Markdown
Collaborator

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2482c1a2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

use: { ...devices["Desktop Chrome"] },
},
]
: [],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fail rather than silently skipping the browser suite

On any Linux Bazel worker missing a Chromium shared library, this branch removes every Playwright project; combined with --pass-with-no-tests in playground/BUILD.bazel, the target succeeds without running any of the tests under playground/tests. I reproduced that outcome in this checkout: the CLI reported Total: 0 tests in 0 files and exited 0. The identical fallback in editors/code/playwright.bazel.config.ts also silently disables the entire extension E2E suite, so missing runtime dependencies should fail the test or be supplied by the Bazel environment rather than produce a green check.

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Benchmark for f3f5fcd

Click to view benchmark
Test Base PR %
DepthMap::from_parent 117.5±3.87µs 128.6±1.74µs +9.45%
fix_complex_query 13.2±0.09ms 13.1±0.09ms -0.76%
fix_superlong 126.3±2.13ms 122.7±3.97ms -2.85%
parse_complex_query 4.1±0.05µs 4.1±0.05µs 0.00%
parse_expression_recursion 6.9±0.07µs 6.9±0.06µs 0.00%
parse_simple_query 1029.8±17.59ns 1033.4±10.47ns +0.35%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant