chore: advance sqlfluff sha past Snowflake GROUP BY ALL (#4976) - #3071
Open
benfdking wants to merge 1 commit into
Open
chore: advance sqlfluff sha past Snowflake GROUP BY ALL (#4976)#3071benfdking wants to merge 1 commit into
benfdking wants to merge 1 commit into
Conversation
benfdking
force-pushed
the
port/sqlfluff-4973
branch
from
August 8, 2026 15:28
eb8562f to
158d2eb
Compare
benfdking
force-pushed
the
port/sqlfluff-4976
branch
from
August 8, 2026 15:28
9f2f63a to
074a486
Compare
Contributor
Benchmark for 5d403dbClick to view benchmark
|
## Summary
- SQLFluff #4976 adds `ALL` support to the Snowflake `GroupByClauseSegment`.
The equivalent change is already present in sqruff: `crates/lib-dialects/src/snowflake.rs`
already lists `Ref::keyword("ALL")` in the `GroupByClauseSegment` `one_of`, and the
`group_by_all` SQL + YAML fixtures already exist under
`crates/lib-dialects/test/fixtures/dialects/snowflake/sqlfluff/`.
- No new code or fixtures are needed; this advances `.sqlfluff-sha` by one first-parent
commit to keep the port sequence in order.
Ported from SQLFluff a20005a6647dbd7fc4ac228897db5b0d776defa7
sqlfluff/sqlfluff#4976
sqlfluff/sqlfluff@a20005a
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q6q9rWEpz9E9GcSrApvWzR
benfdking
force-pushed
the
port/sqlfluff-4973
branch
from
August 8, 2026 17:04
158d2eb to
15b33c0
Compare
benfdking
force-pushed
the
port/sqlfluff-4976
branch
from
August 8, 2026 17:04
074a486 to
1f2bd9f
Compare
Contributor
Benchmark for 4c0855dClick to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALLsupport to the SnowflakeGroupByClauseSegment(group by all).crates/lib-dialects/src/snowflake.rsalready listsRef::keyword("ALL")in theGroupByClauseSegmentone_of.group_by_all.sqlandgroup_by_all.ymlfixtures already exist undercrates/lib-dialects/test/fixtures/dialects/snowflake/sqlfluff/..sqlfluff-shaby one first-parent commit to keep the port sequence in order.Verification
.sqlfluff-shaadvanced from9793de59d54416649c45cb4341d2e2068497a1e2→a20005a6647dbd7fc4ac228897db5b0d776defa7, whose parent is exactly the previous SHA (correct single-commit advance on SQLFluff's first-parentmain).cargo buildand the Snowflake dialect tests (cargo test -p sqruff-lib-dialects) pass; thegroup_by_allfixture parses correctly.//:verify_sqlfluff_sha, which validates the SHA points to a real commit; it will pass in CI (local run hit a403only because the sandbox proxy blocksapi.github.com). The SHA is a valid 40-char hex and resolves to the upstream commit. No Rust code or tests are otherwise affected.Ported from SQLFluff
a20005a6647dbd7fc4ac228897db5b0d776defa7sqlfluff/sqlfluff#4976
sqlfluff/sqlfluff@a20005a
Generated by Claude Code