Skip to content

fix(trino): catch up with SQLFluff and stop panicking on common statements #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkxmercury wants to merge 1 commit into
base: main
Choose a base branch
from
+1,504 −12
Open

fix(trino): catch up with SQLFluff and stop panicking on common statements #3046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
446 changes: 434 additions & 12 deletions crates/lib-dialects/src/trino.rs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions crates/lib-dialects/src/trino_keywords.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ FALSE
FOR
FROM
FULL
FUNCTION
GROUP
GROUPING
HAVING
Expand Down
35 changes: 35 additions & 0 deletions crates/lib-dialects/test/fixtures/dialects/trino/sqlfluff/alter_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
ALTER TABLE t1 RENAME TO t2;
ALTER TABLE IF EXISTS t1 RENAME TO t2;

ALTER TABLE t1 ADD COLUMN col1 VARCHAR;
ALTER TABLE t1 ADD COLUMN IF NOT EXISTS col1 VARCHAR;
ALTER TABLE t1 ADD COLUMN col1 VARCHAR NOT NULL;
ALTER TABLE t1 ADD COLUMN col1 VARCHAR COMMENT 'comment';
ALTER TABLE t1 ADD COLUMN col1 VARCHAR WITH (x = 'y');
ALTER TABLE t1 ADD COLUMN col1 VARCHAR FIRST;
ALTER TABLE t1 ADD COLUMN col1 VARCHAR LAST;
ALTER TABLE t1 ADD COLUMN col1 VARCHAR AFTER col2;

ALTER TABLE t1 DROP COLUMN col1;
ALTER TABLE t1 DROP COLUMN IF EXISTS col1;

ALTER TABLE t1 RENAME COLUMN col1 TO col2;
ALTER TABLE t1 RENAME COLUMN IF EXISTS col1 TO col2;

ALTER TABLE t1 ALTER COLUMN col1 SET DATA TYPE INTEGER;
ALTER TABLE t1 ALTER COLUMN col1 SET DATA TYPE VARCHAR(100);

ALTER TABLE t1 ALTER COLUMN col1 DROP NOT NULL;

ALTER TABLE t1 SET AUTHORIZATION u1;
ALTER TABLE t1 SET AUTHORIZATION USER u1;
ALTER TABLE t1 SET AUTHORIZATION ROLE r1;

ALTER TABLE t1 SET PROPERTIES x = 'y';
ALTER TABLE t1 SET PROPERTIES x = DEFAULT;
ALTER TABLE t1 SET PROPERTIES foo = 123, bar = 456;

ALTER TABLE t1 EXECUTE func;
ALTER TABLE t1 EXECUTE func(x => 'y');
ALTER TABLE t1 EXECUTE func(foo => 123, bar => 456);
ALTER TABLE t1 EXECUTE func(x => 'y') WHERE col1 > 0;
Loading
Loading