Skip to content

Improve Javadoc for CredentialsProvider#51200

Merged
geoand merged 1 commit into
quarkusio:mainfrom
tsegismont:javadoc-credentials-provider
Nov 25, 2025
Merged

Improve Javadoc for CredentialsProvider#51200
geoand merged 1 commit into
quarkusio:mainfrom
tsegismont:javadoc-credentials-provider

Conversation

@tsegismont
Copy link
Copy Markdown
Member

See #50047 (comment)

The goal is to provide guidance to implementors on whether to implement the synchronous or the asynchronous variant.

@tsegismont
Copy link
Copy Markdown
Member Author

@michalvavrik it's not possible to send a PR to the wiki, and I don't believe I'm granted to commit. My plan was to reuse the comments added here to the migration guide. Would you mind taking care of it?

@michalvavrik
Copy link
Copy Markdown
Member

Thanks for the PR.

@michalvavrik it's not possible to send a PR to the wiki, and I don't believe I'm granted to commit. My plan was to reuse the comments added here to the migration guide. Would you mind taking care of it?

I am not a committer, but I think @sberyozkin could also review this PR and add it to the migration guide, since this concerns Quarkus OIDC as well.

@michalvavrik
Copy link
Copy Markdown
Member

Thanks for the PR.

@michalvavrik it's not possible to send a PR to the wiki, and I don't believe I'm granted to commit. My plan was to reuse the comments added here to the migration guide. Would you mind taking care of it?

I am not a committer, but I think @sberyozkin could also review this PR and add it to the migration guide, since this concerns Quarkus OIDC as well.

@geoand could review & add the migration guide as well, I didn't know Georgios was interested / available.

Copy link
Copy Markdown
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsegismont Thanks, LGTM,

I suggested to avoid shortcuts like doesn't as I believe the Doc Team prefers complete ones. The other suggestion is to offer a slightly stronger encouragement to use the async option. I'll let you decide if you'd like to apply them, thanks

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@tsegismont tsegismont requested a review from geoand November 24, 2025 15:41
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Copy Markdown
Contributor

geoand commented Nov 24, 2025

Can you please squash the commits?

Thanks!

See quarkusio#50047 (comment)

The goal is to provide guidance to implementors on whether to implement the synchronous or the asynchronous variant.
@tsegismont tsegismont force-pushed the javadoc-credentials-provider branch from efcbbef to a51222f Compare November 25, 2025 08:49
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 25, 2025
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Nov 25, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a51222f.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Integration Tests - JDK 17 Logs Raw logs 🚧
✔️ JVM Integration Tests - JDK 17 Windows Logs Raw logs 🚧
JVM Integration Tests - JDK 21 Build Failures Logs Raw logs 🚧
✔️ JVM Integration Tests - JDK 21 Semeru Logs Raw logs 🚧
✔️ JVM Integration Tests - JDK 25 Logs Raw logs 🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Integration Tests - JDK 21 #

- Failing: integration-tests/oidc-wiremock 

📦 integration-tests/oidc-wiremock

io.quarkus.it.keycloak.CodeFlowAuthorizationTest. - History - More details - Source on GitHub

Details
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:663)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptBeforeAllMethod(QuarkusTestExtension.java:730)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken line 431 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken(CodeFlowAuthorizationTest.java:431)

Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Condition with Lambda expression in io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:40)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod - History

  • Stream has no elements - java.lang.IllegalArgumentException
Details
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod(MicrometerTimedInterceptorTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:532)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError
Details
java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@geoand geoand merged commit 1ee82e0 into quarkusio:main Nov 25, 2025
64 of 65 checks passed
@quarkus-bot quarkus-bot Bot added this to the 3.31 - main milestone Nov 25, 2025
@quarkus-bot quarkus-bot Bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 25, 2025
@tsegismont tsegismont deleted the javadoc-credentials-provider branch December 17, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants