Skip to content

Fix NoCodes TurboModule spec failing Codegen on React Native 0.84+ #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickSxti wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix NoCodes TurboModule spec failing Codegen on React Native 0.84+ #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/internal/NoCodesInternal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,15 @@ import type {PurchaseDelegate} from '../dto/PurchaseDelegate';
import ScreenPresentationConfig from '../dto/ScreenPresentationConfig';
import NoCodesError from '../dto/NoCodesError';
import {NoCodesErrorCode, NoCodesTheme} from '../dto/enums';
import RNNoCodes, {type NoCodeEvent} from './specs/NativeNoCodesModule';
import RNNoCodes from './specs/NativeNoCodesModule';
import {sdkSource, sdkVersion} from './QonversionInternal';
import Product from '../dto/Product';

type NoCodeEvent = {
name: string;
payload: QNoCodeAction | QNoCodesError | QNoCodeScreenInfo | undefined;
};

const EVENT_SCREEN_SHOWN = "nocodes_screen_shown";
const EVENT_FINISHED = "nocodes_finished";
const EVENT_ACTION_STARTED = "nocodes_action_started";
Expand Down Expand Up @@ -46,7 +51,8 @@ export default class NoCodesInternal implements NoCodesApi {
await RNNoCodes.close();
}

private noCodeEventHandler = (event: NoCodeEvent) => {
private noCodeEventHandler = (rawEvent: Object) => {
const event = rawEvent as NoCodeEvent;
switch (event.name) {
case EVENT_SCREEN_SHOWN:
const screenId = (event.payload as QNoCodeScreenInfo)["screenId"] ?? "";
Expand Down
8 changes: 1 addition & 7 deletions src/internal/specs/NativeNoCodesModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import type { TurboModule } from 'react-native';
import { TurboModuleRegistry } from 'react-native';
import type { EventEmitter } from 'react-native/Libraries/Types/CodegenTypes';
import type { QNoCodeAction, QNoCodesError, QNoCodeScreenInfo } from '../Mapper';

export type NoCodeEvent = {
name: string;
payload: QNoCodeAction | QNoCodesError | QNoCodeScreenInfo | undefined;
};

export interface Spec extends TurboModule {
initialize(projectKey: string, source: string, version: string, proxyUrl?: string, locale?: string, theme?: string): void;
Expand All @@ -23,7 +17,7 @@ export interface Spec extends TurboModule {
delegatedRestoreCompleted(): void;
delegatedRestoreFailed(errorMessage: string): void;

readonly onNoCodeEvent: EventEmitter<NoCodeEvent>;
readonly onNoCodeEvent: EventEmitter<Object>; // NoCodeEvent (defined in NoCodesInternal.ts)
readonly onNoCodePurchase: EventEmitter<Object>; // QProduct
readonly onNoCodeRestore: EventEmitter<void>;
}
Expand Down
Loading