Handle negative imaginary parts in number_to_string (#551)#598
Open
koriyoshi2041 wants to merge 1 commit into
Open
Handle negative imaginary parts in number_to_string (#551)#598koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
number_to_string rebuilt complex numbers via "{real}+{imag}j".format(...).
When the imaginary part is negative this produced an invalid string like
"1.0+-1.0j", and the complex() round-trip raised ValueError -- so
number_to_string(1-1j) and, by extension, DeepHash(1-1j, significant_digits=3)
crashed. Join using the imaginary part's own sign instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551.
number_to_stringreconstructs complex numbers by formatting then re-parsing:When the imaginary part is negative, the formatted
imagalready starts with-, so the literal+produces an invalid string such as"1.0+-1.0j", andcomplex("1.0+-1.0j")raisesValueError: complex() arg is a malformed string.The fix joins
realandimagusing the imaginary part's own sign, so negative imaginary parts produce"1.0-1.0j"instead of"1.0+-1.0j". Positive parts are unchanged.The existing
test_number_to_string_complex_digitscases only exercised non-negative (or rounds-to-zero) imaginary parts. Added two cases with non-zero negative imaginary parts (which raised before the fix); the full parametrized test passes.