Add a16w8 per-op test for gelu by christine-long-meta · Pull Request #19598 · pytorch/executorch

christine-long-meta · 2026-05-14T16:48:00Z

Summary:
Add int16 activation / int8 weight (a16w8) quantization tests for aten.gelu on Ethos-U55 and Ethos-U85.

Changes

Add test_gelu_a16w8_u55_INT using EthosU55PipelineINT with a16w8_quantization=True, symmetric_io_quantization=True, qtol=128, epsilon=2**-16, reusing existing Gelu.test_data parameters (12 test configurations covering both `none` and `tanh` approximation modes)
Add test_gelu_a16w8_u85_INT using EthosU85PipelineINT with same kwargs
Register ops/test_gelu.py in fbcode/ and xplat/ targets.bzl

bypass-pytorch-oss-checks

Reviewed By: Ninja91

Differential Revision: D104532359

pytorch-bot · 2026-05-14T16:48:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19598

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

Run pull request jobs on OSDC runners in shadow mode

✅ You can merge normally! (2 Unrelated Failures)

As of commit ea65d93 with merge base 30c9a26 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / unittest-editable / windows / windows-job (gh) (matched win rule in flaky-rules.json)
##[error]The operation was canceled.
trunk / test-models-linux-aarch64 (ic3, portable, linux.arm64.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2026-05-14T16:48:19Z

~~Workflows were awaiting approval.~~ CI has now been triggered for the ciflow labels on this PR.

github-actions · 2026-05-14T16:48:44Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.gelu` on Ethos-U55 and Ethos-U85. ## Changes - Add `a16w8_gelu_test_parameters` dict with 3 test configurations covering rank-1, rank-2, and rank-3 tensors - Add `test_gelu_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True, qtol=128, epsilon=2**-16` - Add `test_gelu_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_gelu.py` in `fbcode/` and `xplat/` `targets.bzl` bypass-pytorch-oss-checks Differential Revision: D104532359

meta-codesync · 2026-05-14T16:54:06Z

@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532359.

meta-codesync · 2026-05-14T16:54:25Z

@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532359.

meta-codesync · 2026-05-14T16:54:35Z

@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532359.

Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.var` on Ethos-U55 and Ethos-U85. ## Changes - Add `test_var_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True`, reusing existing `Var.test_parameters` (4 test configurations) - Add `test_var_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_var.py` in `fbcode/` and `xplat/` `targets.bzl` bypass-pytorch-oss-checks Differential Revision: D104532362

Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.conv1d` on Ethos-U55 and Ethos-U85. ## Changes - Add `test_conv1d_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True`, reusing existing `test_data_INT` parameters - Add `test_conv1d_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_conv1d.py` in `fbcode/` and `xplat/` `targets.bzl` Reviewed By: Ninja91 Differential Revision: D104532360

Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.gelu` on Ethos-U55 and Ethos-U85. ## Changes - Add `test_gelu_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True, qtol=128, epsilon=2**-16`, reusing existing `Gelu.test_data` parameters (12 test configurations covering both \`none\` and \`tanh\` approximation modes) - Add `test_gelu_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_gelu.py` in `fbcode/` and `xplat/` `targets.bzl` bypass-pytorch-oss-checks Reviewed By: Ninja91 Differential Revision: D104532359

zingo · 2026-05-18T07:35:04Z

You seem to got a strange error in Test ARM Backend, It seems very unrelated, I rerun the tests maybe it was a network glitch and will go away.

zingo

The test re-run passed, approving :) Thanks!

christine-long-meta requested a review from digantdesai as a code owner May 14, 2026 16:48

github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 14, 2026

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2026

christine-long-meta force-pushed the export-D104532359 branch from d718c90 to 1c447dc Compare May 14, 2026 16:48

meta-codesync Bot added fb-exported meta-exported labels May 14, 2026

christine-long-meta force-pushed the export-D104532359 branch from 1c447dc to ea36e20 Compare May 14, 2026 16:48

christine-long-meta force-pushed the export-D104532359 branch from ea36e20 to 42c2abe Compare May 14, 2026 16:53

meta-codesync Bot changed the title ~~Add a16w8 per-op test for gelu~~ Add a16w8 per-op test for gelu (#19598) May 14, 2026

christine-long-meta force-pushed the export-D104532359 branch 2 times, most recently from 15ffc91 to 1371cae Compare May 14, 2026 16:53

christine-long-meta force-pushed the export-D104532359 branch from 1371cae to 60842b0 Compare May 14, 2026 20:53

meta-codesync Bot changed the title ~~Add a16w8 per-op test for gelu (#19598)~~ Add a16w8 per-op test for gelu May 14, 2026

christine-long-meta force-pushed the export-D104532359 branch 3 times, most recently from 1fbd10a to f281d17 Compare May 16, 2026 02:08

meta-codesync Bot changed the title ~~Add a16w8 per-op test for gelu~~ Add a16w8 per-op test for gelu (#19598) May 16, 2026

christine-long-meta added 3 commits May 17, 2026 09:06

meta-codesync Bot changed the title ~~Add a16w8 per-op test for gelu (#19598)~~ Add a16w8 per-op test for gelu May 17, 2026

christine-long-meta force-pushed the export-D104532359 branch from f281d17 to 9781827 Compare May 17, 2026 16:06

zingo approved these changes May 18, 2026

View reviewed changes

Merge branch 'main' into export-D104532359

ea65d93

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a16w8 per-op test for gelu#19598

Add a16w8 per-op test for gelu#19598
christine-long-meta wants to merge 4 commits into
pytorch:mainfrom
christine-long-meta:export-D104532359

christine-long-meta commented May 14, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

pytorch-bot Bot commented May 14, 2026 •

edited

Loading

Uh oh!

pytorch-bot Bot commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

zingo commented May 18, 2026

Uh oh!

zingo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

christine-long-meta commented May 14, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pytorch-bot Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19598

❗ 1 Active SEVs

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

pytorch-bot Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

This PR needs a release notes: label

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

meta-codesync Bot commented May 14, 2026

Uh oh!

zingo commented May 18, 2026

Uh oh!

zingo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

christine-long-meta commented May 14, 2026 •

edited by meta-codesync Bot

Loading

pytorch-bot Bot commented May 14, 2026 •

edited

Loading

pytorch-bot Bot commented May 14, 2026 •

edited

Loading

This PR needs a `release notes:` label