Skip to content

Check for _CountingAttr subclasses #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LecrisUT wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Check for _CountingAttr subclasses #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/attr/_make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def _transform_attrs(
ca_names = {
name
for name, attr in cd.items()
if attr.__class__ is _CountingAttr
if issubclass(attr.__class__, _CountingAttr)
}
ca_list = []
annot_names = set()
Expand All @@ -413,7 +413,7 @@ def _transform_attrs(
annot_names.add(attr_name)
a = cd.get(attr_name, NOTHING)

if a.__class__ is not _CountingAttr:
if not issubclass(a.__class__, _CountingAttr):
a = attrib(a)
ca_list.append((attr_name, a))

Expand All @@ -431,7 +431,7 @@ def _transform_attrs(
(
(name, attr)
for name, attr in cd.items()
if attr.__class__ is _CountingAttr
if issubclass(attr.__class__, _CountingAttr)
),
key=lambda e: e[1].counter,
)
Expand Down
Loading