Skip to content

Replace cached_property on slotted classes with a new descriptor instead of writing __getattr__ #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidCEllis wants to merge 23 commits into
base: main
Choose a base branch
from
+220 −55

Merge branch 'main' into descriptor-cached-property

e015513
Select commit
Loading
Failed to load commit list.
Open

Replace cached_property on slotted classes with a new descriptor instead of writing __getattr__ #1488

Merge branch 'main' into descriptor-cached-property
e015513
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis completed Mar 14, 2026

Performance Regression: -75.19%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_create_cached_property_class 2 s 1.3 s +55.73%
❌ test_repeated_access 237.4 µs 956.7 µs -75.19%

Comparing DavidCEllis:descriptor-cached-property (e015513) with main (21a1028)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (e92fe52) during the generation of this report, so 21a1028 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

View more details on CodSpeed HQ