Skip to content

Ban negative extras (extra != markers) #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konstin wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −9
Open

Ban negative extras (extra != markers) #2085

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
105ab96
Ban negative extras
konstin Jul 4, 2026
fcd6172
Talk about `extra != "name"` too
konstin Jul 19, 2026
36a541f
History entry
konstin Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions source/specifications/dependency-specifiers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,8 @@ DO NOT need to define these fields.

The ``extra`` field is also special, as it expects set-like behaviour, but
predates the addition of ``Set of strings`` as a defined marker field type.
Accordingly, ``extra == "name"`` in a dependency declaration is similar to
``"name" in extras``, while ``extra != "name"`` is similar to
``"name" not in extras``. For dependency marker evaluations, the set of extra
It only supports one operation, ``extra == "name"``, which is similar to
``"name" in extras``. For dependency marker evaluations, the set of extra
names used for these comparisons is the full set of requested extras for *that
particular package*, whether requested directly in a top level dependency
declaration, or indirectly in a transitive dependency declaration. Other
Expand Down
Loading