Establish v2 spec nightly metadata on GitHub Pages deployment#72
Merged
Conversation
Member
Author
|
Okay, all green – I'm merging to try this on GitHub Pages, and I'll open PRs if I have to make follow-up fixes! I'll leave the Pyodide and pyodide-build PRs open as I've requested reviews from you on those, @ryanking13. This is for the nightly environments and thus has no impact, as there's no downstream adoption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.ymlworkflow file now pushes a commit tomain. I chose to not use a PR because it adds a bit of churn, but I can change the approach if askedpages.ymlworkflow to deploy the file on GitHub PagesThere is no v1 file here, just v2, because it's the first time we are doing it and it doesn't make sense to go with the old spec.
I will follow this up by putting together a PR in pyodide-build to use this metadata for those who would like to use nightly and nightly-debug builds.
xref pyodide/pyodide#6248, pyodide/pyodide-build#349