Skip to content

Raise opentelemetry-sdk ceiling to <1.44.0 (allow 1.43) #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hramezani wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Raise opentelemetry-sdk ceiling to <1.44.0 (allow 1.43) #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46a704
Raise opentelemetry-sdk/exporter ceiling to <1.44.0
hramezani Jun 30, 2026
2401950
Keep tests deterministic across the OTel 1.42/1.43 boundary
hramezani Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion logfire/_internal/exporters/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,12 @@ def process_attribute(
assert value == os.getpid()
return 1234
if name == 'service.instance.id':
if re.match(r'^[0-9a-f]{32}$', value):
# OpenTelemetry <=1.42 set this to `uuid4().hex` (32 hex chars); 1.43+ uses the

@alexmojaki alexmojaki Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, otel didn't set this before at all, logfire did. This points to the need for a change in config.py, not tests.

The otel change is here: https://github.com/open-telemetry/opentelemetry-python/pull/5259/changes#diff-d2c46fd8da8afdf67c6ad3dd42b0a243c5049f3c720d9bb3351f1d5522338b06R472

The spec is here: https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/#service-instance-id

Also see the docs: https://pydantic.dev/docs/logfire/reference/sql/#service_instance_id

The otel change is causing a change in the documented logfire behaviour. logfire generates a new random UUID for each call to logfire.configure(), whereas it looks like otel holds onto a stable global value. A decision needs to be made about this.

cc @dmontagu who was recently involved in code changes in this area.

@hramezani hramezani Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two options:

  • Defer to OTel — drop our fallback, update docs
  • Preserve current behaviour — re-assert our own id above OTel's detector while still letting OTEL_RESOURCE_ATTRIBUTES/user detectors win.

# dashed UUID form. Normalise either representation to a fixed value so snapshots
# stay deterministic across OTel versions.
if re.match(r'^[0-9a-f]{32}$', value) or re.match(
r'^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$', value
):
return '0' * 32
if parse_json_attributes and isinstance(value, str) and (value.startswith('{') or value.startswith('[')):
try:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ classifiers = [
"Framework :: OpenTelemetry :: Instrumentations",
]
dependencies = [
"opentelemetry-sdk >= 1.39.0, < 1.43.0",
"opentelemetry-exporter-otlp-proto-http >= 1.39.0, < 1.43.0",
"opentelemetry-sdk >= 1.39.0, < 1.44.0",
"opentelemetry-exporter-otlp-proto-http >= 1.39.0, < 1.44.0",
"opentelemetry-instrumentation >= 0.41b0",
"rich >= 13.4.2",
"protobuf >= 4.23.4",
Expand Down
5 changes: 4 additions & 1 deletion tests/exporters/test_otlp_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import pytest
import requests
import requests.exceptions
from dirty_equals import IsStr
from inline_snapshot import snapshot
from opentelemetry.sdk.trace.export import SpanExportResult
from requests.models import PreparedRequest, Response as Response
Expand Down Expand Up @@ -45,7 +46,9 @@ def test_max_body_size_bytes() -> None:
exporter.max_body_size = 10
with pytest.raises(BodyTooLargeError) as e:
exporter.export(TEST_SPANS)
assert str(e.value) == snapshot('Request body is too large (897045 bytes), must be less than 10 bytes.')
# The exact serialized size depends on the OpenTelemetry version, so match the message shape
# rather than a hardcoded byte count.
assert str(e.value) == IsStr(regex=r'Request body is too large \(\d+ bytes\), must be less than 10 bytes\.')


def test_connection_error_retries(monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture) -> None:
Expand Down
4 changes: 2 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading