Skip to content

Remove logfire.variables_clear since it's for tests, not users #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexmojaki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove logfire.variables_clear since it's for tests, not users #2033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10fc5b6
Remove logfire.variables_clear since it's for tests, not users
alexmojaki Jun 18, 2026
395b3cb
Merge branch 'main' into alex/hide-variables-clear
alexmojaki Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions logfire/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
# Variables
var = DEFAULT_LOGFIRE_INSTANCE.var
template_var = DEFAULT_LOGFIRE_INSTANCE.template_var
variables_clear = DEFAULT_LOGFIRE_INSTANCE.variables_clear
variables_get = DEFAULT_LOGFIRE_INSTANCE.variables_get
variables_push = DEFAULT_LOGFIRE_INSTANCE.variables_push
variables_push_types = DEFAULT_LOGFIRE_INSTANCE.variables_push_types
Expand Down Expand Up @@ -203,7 +202,6 @@ def loguru_handler() -> Any:
'variables',
'var',
'template_var',
'variables_clear',
'variables_get',
'variables_push',
'variables_push_types',
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def config_kwargs(

@pytest.fixture(autouse=True)
def config(config_kwargs: dict[str, Any], metrics_reader: InMemoryMetricReader) -> None:
logfire.variables_clear()
logfire.DEFAULT_LOGFIRE_INSTANCE.variables_clear()
configure(
**config_kwargs,
metrics=logfire.MetricsOptions(
Expand Down
Loading