-
Notifications
You must be signed in to change notification settings - Fork 33
update item and liquid names for EN/RU locales #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,9 +57,9 @@ inductor3=High-frequency SMD inductors | |
| capacitor1=Ceramic capacitors | ||
| capacitor2=Electrolytic capacitors | ||
| capacitor3=Multilayer SMD capacitors | ||
| resistor1=High-power resistors | ||
| resistor2=Medium-power resistors | ||
| resistor3=Low-power resistors | ||
| resistor1=Carbon composite resistors | ||
| resistor2=Wirewound resistors | ||
| resistor3=SMD metal-film resistors | ||
| graphite=Graphite | ||
| vacuum-tube=Vacuum tube | ||
| diode=Diodes | ||
|
|
@@ -68,11 +68,11 @@ transistor=Transistors | |
| microchip=Microchips | ||
| fiberboard=Fiberboard | ||
| formica=Formica | ||
| pcb1=Printed circuit substrate (tier 1) | ||
| pcb2=Printed circuit substrate (tier 2) | ||
| pcb3=Printed circuit substrate (tier 3) | ||
| pcb3-2=Mounted circuit substrate | ||
| pcb4=Printed circuit substrate (tier 4) | ||
| pcb1=Blank PCB (tier 1) | ||
| pcb2=Blank PCB (tier 2) | ||
| pcb3=Blank PCB (tier 3) | ||
| pcb3-2=Pre-assembled PCB (tier 3) | ||
| pcb4=Blank PCB (tier 4) | ||
| electronic-circuit=Simple circuit board | ||
| advanced-circuit=Complex circuit board | ||
| processing-unit=High tech circuit board | ||
|
|
@@ -102,7 +102,7 @@ nic-core=Nickel core | |
| pdms-graphene=PDMS graphene base | ||
| graphene-sheet=Graphene sheet | ||
| graphene-roll=Graphene roll | ||
| processor-core=Processor core | ||
| processor-core=Processor die | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a clear reason to change from matching the internal name here? |
||
| processor=Processor | ||
| phosphate-glass=Phosphate glass | ||
| high-flux-core=High Flux core | ||
|
|
@@ -121,7 +121,7 @@ nanochip=Nanochip | |
| raw-fiber=Raw fiber | ||
| fiber=Fiber | ||
| micro-fiber=Microfiber | ||
| sub-denier-microfiber=Sub denier microfiber | ||
| sub-denier-microfiber=Ultra-fine microfiber | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better to match the prototype name here |
||
| resorcinol=Resorcinol | ||
| rf-gel=RF gel | ||
| clean-rf-gel=Clear RF gel | ||
|
|
@@ -141,8 +141,8 @@ zinc-nanocompound=Zinc nanocompound | |
| zinc-nanocomplex=Zinc nanocomplex | ||
| zno-nanoparticles=Zinc oxide nanoparticles | ||
| csle-diode=Cross section light emitting diode | ||
| ndfeb-alloy=Neodymium ferroboron alloy | ||
| ndfeb-powder=Neodymium ferroboron powder | ||
| ndfeb-alloy=Nd-Fe-B alloy | ||
| ndfeb-powder=Nd-Fe-B powder | ||
|
Comment on lines
+144
to
+145
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Generally, it's better to keep the full name and add the abbreviation in brackets, like PDMS on line 100 does. I suggest: The lack of dashes allows searches to match the shorthand and prototype name. |
||
| re-magnet=Neodymium magnet | ||
| sc-substrate=Superconductor substrate | ||
| superconductor=Superconductor | ||
|
|
@@ -157,7 +157,7 @@ bones=Bones | |
| skin=Skin | ||
| meat=Meat | ||
| fertilizer=Fertilizer | ||
| rayon=Rayon | ||
| rayon=Viscose | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you explain the rationale for this change? |
||
| blood-meal=Blood meal | ||
| nylon=Nylon | ||
| nylon-parts=Nylon parts | ||
|
|
@@ -180,10 +180,10 @@ harmonic-absorber=Harmonic absorber | |
| pyrolytic-carbon=Pyrolytic carbon | ||
| nv-center=Nitrogen vacancy center | ||
| quantum-dots=Quantum dots | ||
| pi-josephson-junction=Pi Josephson junction | ||
| var-josephson-junction=Varphi Josephson junction | ||
| pi-josephson-junction=π-Josephson junction | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These symbols aren't easily searchable for users
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and if you search "pi"? Largely, people tend to enter the item name from left to right. I think it's worth keeping usable over using the symbols, most people also won't be able to tell you what the varphi symbol denotes.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand this might cause inconvenience for some players. But: If a player wants to find this item, they either know it's a "Josephson junction" - and they type "Josephson" or "junction", or they don't know - then they won't be searching for it at all. There are already precedents in the German localization, for example π-Josephson-Kreuzung and γ-Butyrolacton (GBL). So German players manage just fine - and they don't complain. In physics, these junctions are called exactly π-Josephson junction and φ-Josephson junction. The mod is complex, and it can cause suffering for players even with Greek letters. These letters are taught in school during math and physics classes. If a player skipped school — the mod will teach them (educational gaming, yay). I suggest using π and φ because it's correct, it educates, and so that players get humiliated by complex letters. We should ask other developers for their opinion on this matter.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked with other developers and the consensus is that the original remains. This is due to:
Supplementary to this is matching the internal prototype names, though this is a minor point since 'varphi' is already abbreviated as 'var' |
||
| var-josephson-junction=φ-Josephson junction | ||
| quantum-vortex-storage-system=Quantum vortex storage system | ||
| bose-einstein-superfluid=Bose Einstein superfluid | ||
| bose-einstein-superfluid=Bose-Einstein superfluid | ||
| antimatter=Antimatter | ||
| crystallographic-substrate=Crystallographic substrate | ||
| proton-donor=Proton donor | ||
|
|
@@ -203,9 +203,9 @@ ceramic=Basic ceramic. | |
| capacitor1=First generation capacitors. | ||
| capacitor2=Great multipurpose capacitors, with a delicious liquid center! Don't let them bulge though... | ||
| capacitor3=Multilayer ceramic chip capacitors (MLCC) for complex PCBs. | ||
| resistor1=Can withstand high currents without burning out. | ||
| resistor2=Thick film resistors, suitable for use in a wide range of applications. | ||
| resistor3=Third generation resistors, suitable for low-power applications only. | ||
| resistor1=Passive component, resistance is provided by a carbon composite material. | ||
| resistor2=Passive component, resistance is provided by high-resistivity wire wound on a frame. | ||
| resistor3=Passive component, resistance is provided by a metal film on a ceramic substrate. | ||
| inductor1=First generation inductors. | ||
| inductor2=Cute metal donuts. May be inedible though. | ||
| inductor3=High-performance inductors in a small SMD package. | ||
|
|
@@ -225,7 +225,7 @@ rf-gel=Resorcinol formaldehyde gel. | |
| kondo-substrate=A place to build the powerful Kondo processor. | ||
| heavy-fermion=Unconventional superconductor. | ||
| kondo-processor=Able to make 1PT of Kondo calculations per second. | ||
| ndfeb-alloy=Neodimium iron boron alloy. | ||
| ndfeb-alloy=Alloy consisting of neodymium (Nd), iron (Fe), and boron (B). Possesses outstanding magnetic properties. | ||
| intelligent-unit=Can you prove you're self aware? | ||
| zipir-carcass=It was killed with mercy. | ||
| rayon=Advanced fiber with many uses. | ||
|
|
@@ -237,6 +237,7 @@ blackhole-fuel=It doesn't. | |
| ht-locomotive=Nexelit powered locomotive. | ||
| nexelit-battery=Special energy unit made to power up the most modern transportation systems. | ||
| used-nexelit-battery=No energy left. | ||
| ndfeb-powder=Ground alloy of neodymium (Nd), iron (Fe), and boron (B). Used for producing permanent magnets via sintering. | ||
|
|
||
| [fluid-name] | ||
| methane=Methane | ||
|
|
@@ -260,7 +261,7 @@ chloromethane=Chloromethane | |
| dimethyldichlorosilane=Dimethyldichlorosilane | ||
| dms=Dimethyl sulfide (DMS) | ||
| msa=Methanesulfonic acid (MSA) | ||
| bacteria-2=Knallgas-bacteria | ||
| bacteria-2=Knallgas bacteria | ||
| soaked-gel=Soaked gel | ||
| acrolein=Acrolein | ||
| acetic-acid=Acetic acid | ||
|
|
@@ -433,7 +434,7 @@ parametric-oscilator=Optical parametric oscillator | |
| phenol=Phenol | ||
| phosphorous-processing=Phosphorous processing | ||
| propene=Propene | ||
| rayon=Rayon | ||
| rayon=Viscose | ||
| re-magnet=Neodymium magnet | ||
| supercapacitor=Supercapacitor | ||
| superconductor=Superconductor | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure on this one, the original naming has a clear tiering to it while the replacement names do not.
Do you have a rationale for the changes?