Skip to content

chore: improve dowhy maintenance path#1566

Open
lphuc2250gma wants to merge 1 commit into
py-why:mainfrom
lphuc2250gma:maint/20260606035158
Open

chore: improve dowhy maintenance path#1566
lphuc2250gma wants to merge 1 commit into
py-why:mainfrom
lphuc2250gma:maint/20260606035158

Conversation

@lphuc2250gma
Copy link
Copy Markdown

Summary:

  • Add or tighten focused edge-case tests or type assertions in tests/gcm/test_ml.py, tests/gcm/test_auto.py related to Python typing, tests, CLI ergonomics, observability; avoid docs-only changes and broad refactors.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@amit-sharma amit-sharma requested a review from bloebp June 6, 2026 04:06
Comment thread tests/gcm/test_auto.py

def test_when_assign_causal_mechanisms_then_returns_auto_assignment_summary():
causal_model = ProbabilisticCausalModel(nx.DiGraph([("X", "Y")]))
data = pd.DataFrame({"X": [1, 2, 3], "Y": [1, 2, 3]})
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is failing because there is insufficient data to run 5-fold validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants