Skip to content

shading: use morphology.footprint_rectangle((1, 3)) for 1x3 structuring element #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwhanse merged 6 commits into from
Jul 8, 2026
Merged

shading: use morphology.footprint_rectangle((1, 3)) for 1x3 structuring element #233

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
893f8ca
shading: use morphology.footprint_rectangle((1, 3)) for 1x3 structuri…
Omesh37 Jul 2, 2026
cfd31c9
Fix read-only array error in _prepare_images by copying to_numpy() ou…
Omesh37 Jul 4, 2026
553b9d5
Move footprint_rectangle import to module level with version fallback…
Omesh37 Jul 8, 2026
394267b
Apply suggestion from @cwhanse
cwhanse Jul 8, 2026
e976c1f
fixed flake8 error
Omesh37 Jul 8, 2026
f3e8713
Fix DatetimeIndex.diff() AttributeError in completeness_score
Omesh37 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pvanalytics/features/shading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from skimage import morphology, measure
import pvlib
from pvanalytics import util

from skimage.morphology import footprint_rectangle
Comment thread
cwhanse marked this conversation as resolved.
Outdated
from skimage.morphology import rectangle as footprint_rectangle

def _to_image(data, width):
"""Convert data to an image.
Expand Down Expand Up @@ -113,7 +114,7 @@ def _prepare_images(ghi, clearsky, daytime, interval):
ghi_image = pd.DataFrame(cloudless_image).interpolate(
axis=0,
limit_direction='both'
).to_numpy()
).to_numpy().copy()
# set night to nan
ghi_image[~_to_image(daytime.to_numpy(), image_width)] = np.nan
return (
Expand Down Expand Up @@ -365,7 +366,7 @@ def fixed(ghi, daytime, clearsky, interval=None, min_gradient=2):
threshold = gradient > min_gradient # binary image of wire candidates

# From here we CAN use skimage because we are working with binary images.
three_minute_mask = morphology.rectangle(1, 3)
three_minute_mask = footprint_rectangle(1, 3)
wires = morphology.remove_small_objects(
morphology.binary_closing(threshold, three_minute_mask),
min_size=200,
Expand Down
Loading