Skip to content

build: 🧑‍💻 Add more warning flags to kernel#738

Open
ion098 wants to merge 8 commits into
purduesigbots:develop-pros-4from
ion098:build/more-warnings
Open

build: 🧑‍💻 Add more warning flags to kernel#738
ion098 wants to merge 8 commits into
purduesigbots:develop-pros-4from
ion098:build/more-warnings

Conversation

@ion098

@ion098 ion098 commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Summary:

Adds more warning flags to PROS kernel.

Motivation:

These warning flags would have caught issues like #736 at compile time.

Test Plan:

  • Check that kernel compiles

@ion098 ion098 changed the title build: 🧑‍💻 Add more warning flags to makefile build: 🧑‍💻 Add more warning flags to kernel Jan 16, 2025
@Rocky14683

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AndrewLuGit

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AndrewLuGit

Copy link
Copy Markdown
Contributor

I don't think adding -Werror is a good idea.

@ion098

ion098 commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

re @AndrewLuGit

I don't think adding -Werror is a good idea.

I would disagree with you, save for the fact that I don't feel like fixing 525 errors at the moment. That being said, some of these warnings should probably be fixed at a later time.

@Rocky14683

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants