-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: prevent browser freeze when tessellating >50k vertices (#8219 ) #8555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nixxx19
wants to merge
4
commits into
processing:main
Choose a base branch
from
Nixxx19:nityam/tessellation-freeze-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−0
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
051df1e
fix: prevent browser freeze when tessellating >50k vertices
Nixxx19 100bb2b
Merge branch 'processing:main' into nityam/tessellation-freeze-fix
Nixxx19 61d9d17
feat(webgl): prompt before tessellating very large shapes
Nixxx19 0b6f376
fix test timeout by stubbing tessellation in large shape tests
Nixxx19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like tests are currently failing here:
Does this test also take a while locally?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry about that! the test was timing out because when
p5.disableFriendlyErrorsis true, the prompt is skipped and tessellation actually runs on 60k vertices, which is the freeze we're trying to guard against. fixed by stubbing_tesselateShapein the tests that would otherwise trigger real tessellation. also added an assertion that_tesselateShapeis called in thedisableFriendlyErrorscase to confirm the code path is exercised. applied the same stub to the "only prompts once" test as well since confirm returns true there.