Refactor probnum.typing#599
Merged
marvinpfoertner merged 15 commits intoDec 30, 2021
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 180 180
Lines 6668 6670 +2
Branches 1025 1025
=======================================
+ Hits 5960 5962 +2
Misses 479 479
Partials 229 229
|
JonathanWenger
approved these changes
Dec 30, 2021
JonathanWenger
left a comment
Contributor
There was a problem hiding this comment.
Nice. This will be great to u ify interfaces in particular in light of the planned backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR refactors the global
probnum.typingmodule, preparing it for #581.Detailed Description
...ArgTypes to...LiketypesToleranceDiffusionTypeandDenseOutputLocationArgType, which are just aliases forArrayLikeRelated Issues and PRs
#581