Skip to content

Start documenting some undocumented player data #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItsLeaze wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Start documenting some undocumented player data #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/overlay066/ov66_0222DDF0.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,21 @@ UnkStruct_ov66_0222E71C *ov66_0222E3BC(UnkStruct_ov66_0222DFF8 *param0);
void ov66_0222E3E4(UnkStruct_ov66_0222DFF8 *param0, int param1);
void ov66_0222E500(UnkStruct_ov66_0222DFF8 *param0, int param1, s32 param2);
void ov66_0222E528(UnkStruct_ov66_0222DFF8 *param0, u32 param1);
void ov66_0222E56C(UnkStruct_ov66_0222DFF8 *param0, int param1, int param2);
void ov66_0222E56C(UnkStruct_ov66_0222DFF8 *param0, int type1, int type2);
void ov66_0222E5D8(UnkStruct_ov66_0222DFF8 *param0, u32 param1, u32 param2);
void ov66_0222E640(const UnkStruct_ov66_0222E71C *param0, TrainerInfo *param1, enum HeapID heapID);
u32 ov66_0222E71C(const UnkStruct_ov66_0222E71C *param0);
int ov66_0222E728(const UnkStruct_ov66_0222E71C *param0, u32 param1);
s32 ov66_0222E760(const UnkStruct_ov66_0222E71C *param0, u32 param1);
s32 ov66_0222E798(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E79C(const UnkStruct_ov66_0222E71C *param0);
u32 GetTrainerID(const UnkStruct_ov66_0222E71C *param0);
Copy link
Copy Markdown
Collaborator

@ravepossum ravepossum Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: We follow the general convention of Module_Function() when naming non-static functions to minimize namespace issues and mimic the pseudo-OOP structure of the game. Since that hasn't been identified yet here, you'll need to identify that. This would go for all the non-static functions here.

We have a list of descriptions of each overlay here which indicates that overlay66 is for the Wi-Fi Plaza orchestrator. There's a handful of files in this overlay though, so it's one specific part of the plaza orchestrator. If you're having trouble identifying or naming the module, feel free to ask in the discord.

int ov66_0222E7A0(const UnkStruct_ov66_0222E71C *param0);
UnkStruct_ov66_02231428 ov66_0222E7C4(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E7C8(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E80C(const UnkStruct_ov66_0222E71C *param0);
u32 GetGender(const UnkStruct_ov66_0222E71C *param0);
Copy link
Copy Markdown
Collaborator

@ravepossum ravepossum Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: It may also be a good idea to identify what exactly UnkStruct_ov66_0222E71C is before naming these functions. I don't want to expand the scope of the PR (I think starting small is good), but we tend to hold off on naming functions until we're certain we know what they do. When reviewing, I apply a lot more scrutiny to a named function than one left unnamed. Leaving a function (or anything really) unnamed that you're not sure about is perfectly valid.

u32 GetNormalizedLanguage(const UnkStruct_ov66_0222E71C *param0);
BOOL ov66_0222E824(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E850(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E858(const UnkStruct_ov66_0222E71C *param0);
u32 GetLanguage(const UnkStruct_ov66_0222E71C *param0);
u32 GetTrainerAppearance(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E880(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E8A4(const UnkStruct_ov66_0222E71C *param0);
u32 ov66_0222E8C4(const UnkStruct_ov66_0222E71C *param0);
Expand Down
Loading
Loading