Open
Conversation
lhearachel
reviewed
Mar 28, 2026
Comment on lines
+81
to
+85
| typedef struct order_template order_template_t; | ||
| struct order_template { | ||
| const char *out_filename; | ||
| FILE *out_file; | ||
| }; |
Collaborator
There was a problem hiding this comment.
question: Couldn't this just be a header_template_t without a header and footer? e.g., just use a file in tools/dataproc/data that only has the magic comment-string. I think that might require some refactoring to support a generic template name, though, rather than one that maps to the expected output filename.
Collaborator
Author
There was a problem hiding this comment.
My thought was to be explicit about the intention of the file and skip the header_comment
Collaborator
There was a problem hiding this comment.
That's fair! Something we might consider, then, is making the common_init API more extensible by passing a meta-struct (or a pointer to one) that contains all of these templates.
Collaborator
Author
|
Addressed comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the species front and back sprites narc generation from a python script to meson generators. The order file is an additional output to
speciesproc.