Decomp overlay44 02235340 and 02232E9C#464
Conversation
| if (arg0->unk6CC == NULL) { | ||
| GF_AssertFail(); | ||
| } |
There was a problem hiding this comment.
All if { GF_AssertFail } might be replaceable with GF_ASSERT() directly.
Example here: GF_ASSERT(arg0->unk6CC != NULL);
|
|
||
| FS_EXTERN_OVERLAY(OVY_42); | ||
|
|
||
| void ov44_02232EA8(OverlayManager* overlayMananger) { |
There was a problem hiding this comment.
Surely is ov44_Init (name suggestion)
| temp_r0->unk27 = 1; | ||
| } | ||
|
|
||
| s32 ov44_02232F64(OverlayManager* overlayManager, u32* arg1) { |
There was a problem hiding this comment.
Then ov44_Main (the main loop, with the state machine)
| return 0; | ||
| } | ||
|
|
||
| s32 ov44_022330A8(OverlayManager* arg0) { |
There was a problem hiding this comment.
Finally ov44_Exit (when overlay is unloaded, freeing all allocated objects etc.)
|
This has merge conflicts with your other PR that got submitted. Usually to prevent this going forward you'll want to have one PR be a branch of the other. |
|
please resolve conflicts, also, nathan's suggestions are a good point for improvement |
|
Going to close this for now until I finish the rest of overlay_44 to make sure I get the correct file boundaries |
4 participants
No description provided.