fix dependency order for zukan_hw_data to fix build#453
Merged
adrienntindall merged 4 commits intopret:masterfrom Apr 14, 2026
Merged
fix dependency order for zukan_hw_data to fix build#453adrienntindall merged 4 commits intopret:masterfrom
adrienntindall merged 4 commits intopret:masterfrom
Conversation
red031000
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(ZUKAN_HW_DATA_NAIX)needs to be dependent on$(ZUKAN_HW_DATA_NARC)to ensure that the narc is built (and version-specific naix is generated) first. there was also never a rule for the version-specific naix, so the makefile would get mad that the file did not exist and there was not a rule for itan example of a failed run over on hg-engine
hg-engine uses pokeheartgold to build a rom on gh actions to use as a base for injection. this is paranoia on part of one of the maintainers over there, but it has been showing this behavior over the past few days