Open
Conversation
decompiled unk_02067A60 and named most everything, updated the call and include names where they appeared. Built with no issues.
PikalaxALT
requested changes
Jan 30, 2026
Comment on lines
+147
to
+152
| u8 *p = (u8 *)env; | ||
| u32 i = sizeof(FlyTaskEnv); | ||
| do { | ||
| *p++ = 0; | ||
| i--; | ||
| } while (i != 0); |
Collaborator
There was a problem hiding this comment.
this looks like a memset call
Contributor
There was a problem hiding this comment.
Something like this I guess:
Suggested change
| u8 *p = (u8 *)env; | |
| u32 i = sizeof(FlyTaskEnv); | |
| do { | |
| *p++ = 0; | |
| i--; | |
| } while (i != 0); | |
| memset(env, 0, sizeof(FlyTaskEnv)); |
|
This pull request has had no activity for 60 days and will be marked stale. If there is no further activity, it will be closed in 30 days. |
Member
|
bump, request memset change as above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompiled unk_02067A60 and named most everything, updated the call and include names where they appeared. Built with no issues.