fix: allow unsetting unknown config keys#6336
Closed
noezhiya-dot wants to merge 1 commit into
Closed
Conversation
The pixi config unset command errors when trying to unset a key that doesn't exist in the Rust config struct (e.g. removed/deprecated options like repodata-config.disable-jlap). Since the goal of unset is to remove a key, and a non-existent key is already effectively unset, this should be a no-op rather than an error. Fixes prefix-dev#5672
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pixi config unseterrors when trying to unset a key that doesn't exist in the Rust config struct (e.g. removed/deprecated options likerepodata-config.disable-jlap). Since the goal ofunsetis to remove a key, and a non-existent key is already effectively unset, this should be a no-op rather than an error.The fix modifies
alter_configincrates/pixi_cli/src/config.rsto silently ignore "Unknown key" errors when inUnsetmode, while still propagating other errors (e.g. invalid value types).Fixes #5672
How Has This Been Tested?
AI Disclosure
Tools: OWL (openrouter/owl-alpha)
Checklist:
schema/model.py.