fix: resolve initialization manifest bugs and restructure the init module#6294
Open
samrosenf wants to merge 4 commits into
Open
fix: resolve initialization manifest bugs and restructure the init module#6294samrosenf wants to merge 4 commits into
samrosenf wants to merge 4 commits into
Conversation
- Fix incorrect manifest name in bail error when format is Mojoproject - Ensure default name is PyPI-safe when extending pyproject by stripping invalid characters - Add comprehensive integration tests covering all init function manifest creation paths
- Introduce InitStrategy enum to handle manifest creation variations cleanly - Extract validation, channel resolution, and SCM file creation into helper functions - Group rendering parameters into a unified RenderContext struct
…or/pixi-api-init
Contributor
Author
|
Hey @baszalmstra, would you mind reviewing my changes? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2523 (partially, it's a preparation step)
How Has This Been Tested?
As I said above, I added comprehensive integration tests covering all init function manifest creation paths
AI Disclosure
Tools:
I used Gemini (mostly Flash, a bit of Pro) from the web to ask questions, but not directly from the IDE.
I wrote everything and take responsibility of the code in this PR.
Checklist: