Add wolf-sheep-soil-creep tutorial#793
Conversation
There was a problem hiding this comment.
Hi @joargu! This PR is coming out of the blue for me, but it might be the cleanest PR I have ever reviewed for a new tutorial! 😄
I can run the tutorial on my system, which completes in a few seconds (very good for a tutorial). There are no external adapters used, since the two codes are given (both in Python, both already with requirements.txt). I think this would be a nice tutorial, both to showcase coupling with an ABM code, and to showcase a very different application.
You could also add the two codes in the list of third-party adapters, including contact details. At the moment, I have no idea of the context/contact.
I only have two points where this needs improvement: a bit more description, and a fix in the plotting.
Time-wise, this is also good: We are about to make a new release of the tutorials, and it would be great to have this in there.
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
|
The plotting issue should be fixed now. The figure PNGs are written to |
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
|
I was able to run the case and reproduce the expected results. |
|
I extended the tutorial description, mentioned the source notebook and licensing, and added a note about the output directory under post-processing. |
|
FYI, @joargu, once you are ready with the open points (I see there are a couple of unresolved conversations), I could also directly integrate this case into the system tests, so that we know that it will keep running in the future. |
|
Thanks! All open points should be resolved now. |
Description
Added a new wolf-sheep-soil-creep tutorial coupling Mesa (ABM) and Landlab (PDE) via preCICE.
Checklist
changelog-entries/<PRnumber>.md.