Incorrect height of panel with multiple items in row#848
Open
soarer1004 wants to merge 6 commits intopqina:masterfrom
Open
Incorrect height of panel with multiple items in row#848soarer1004 wants to merge 6 commits intopqina:masterfrom
soarer1004 wants to merge 6 commits intopqina:masterfrom
Conversation
Collaborator
|
appreciate the PR will review when I have some time |
|
I think this PR might help with the problem I'm having. When I add some invalid file with some other valid files, the container loses height because it sets the new height according to the height of the invalid file and not everyone inside the container. |
|
I used a work around by simply giving all items (containers) the same (minimal) height and a border in an additional CSS file: Additionally I gave the drop area a fixed height, in my case the whole page. Maybe that works for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is multiple images with different height in one row, panel height calculates incorrect because based on first child height. Also rows can overlap each other if add images with different height.
Example