sys: Prefix capability enum values with architecture#1770
Open
mkannwischer wants to merge 1 commit into
Open
Conversation
Disambiguate the mlk_sys_cap values by architecture:
MLK_SYS_CAP_{AVX2,SHA3,MVE} become
MLK_SYS_CAP_{X86_64_AVX2,AARCH64_SHA3,ARMV81M_MVE}.
Generate the ABI checker tests before the macro-typo check in autogen
so the renamed values in the generated check files pass validation,
and drop the unused MLK_SYS_CAP_DUMMY allowlist entry.
Patch AWS-LC accordingly.
- Ports pq-code-package/mldsa-native#1208
- Resolves #1320
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disambiguate the mlk_sys_cap values by architecture: MLK_SYS_CAP_{AVX2,SHA3,MVE} become
MLK_SYS_CAP_{X86_64_AVX2,AARCH64_SHA3,ARMV81M_MVE}.
Generate the ABI checker tests before the macro-typo check in autogen so the renamed values in the generated check files pass validation, and drop the unused MLK_SYS_CAP_DUMMY allowlist entry.
Patch AWS-LC accordingly.