Skip to content

Update Symfony packages to version 5 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piotrbelina wants to merge 1 commit into from
Closed

Update Symfony packages to version 5 #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
},
"require": {
"php": "^7.1",
"symfony/console": "^4.0",
"symfony/finder": "^4.0",
"symfony/console": "^4.0 || ^5.0",
Copy link
Copy Markdown
Contributor

@richardhughes richardhughes Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come your using the || operator here? Cant we just update it to 5.0 and then bump up the major release version?

Copy link
Copy Markdown

@SignpostMarv SignpostMarv Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR (and this comment) is a duplicate of #102

Copy link
Copy Markdown
Author

@piotrbelina piotrbelina Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just learned it. #102 has title "fixes #98" which does not speak much

"symfony/finder": "^4.0 || ^5.0",
"nikic/php-parser": "^4.0",
"jakub-onderka/php-console-highlighter": "^0.4",
"phpunit/php-timer": "^2.0"
Expand Down