fixes #98#102
Conversation
|
scrutinizer / appveyor failures do not appear related to changes made. |
| - php: 7.2 | ||
| env: COMPOSER_FLAGS="--prefer-lowest" | ||
| - php: 7.3 | ||
| - php: 7.3 |
There was a problem hiding this comment.
These meant to be duplicated?
There was a problem hiding this comment.
yes.
- php: 7.3
- php: 7.3
env: COMPOSER_FLAGS="--prefer-lowest"the first entry runs without the COMPOSER_FLAGS set, the second entry runs with it.
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^7.0", | ||
| "phpunit/phpunit": "^7.5.20|^8.5|^9.0", |
There was a problem hiding this comment.
How come your using the | operator here? Can't we just use the latest version of these packages and then bump up the major release version when this gets merged?
There was a problem hiding this comment.
different packages have different minimum php requirements .
the purpose of this PR is not to change the minimum php requirement of povils/phpmnd.
compatibility with phpunit/php-timer can't be verified by tests if it isn't installed in CI
SignpostMarv
force-pushed
the
fix/issue-98
branch
from
309a88e to
bec7244
Compare
compatibility with phpunit/php-timer can't be verified by tests if it isn't installed in CI
|
@SignpostMarv The build is failing any chance you can look ? |
|
@exussum12 currently awaiting return of computer so I can work on dev things again. |
|
@exussum12 computer returned today, will need to schedule time this week to look at a rebase/merge |
compatibility with phpunit/php-timer can't be verified by tests if it isn't installed in CI
|
looks good to me. Thanks. @sidz happy with this one ? |
sidz
left a comment
sidz
left a comment
There was a problem hiding this comment.
I'm ok.
p.s. I'm thinking about dropping support for old version (not in this PR and after 2.5 release)
|
it's probably worth mentioning that as this PR is a little over a year old, I've lost the original context for when the issue occurs 🤷♂️ |
|
@SignpostMarv I assume that there were some incompatibility issues with newest symfony/console. Currently we need to bump up minimum version of we will do it in separate branch |
6 participants
ReflectionType::__toString()usage.