Add fields for TLS material to destination config#340
Merged
Conversation
(Resuming from containers/common#2249) Signed-off-by: Andrew Melnick <meln5674.5674@gmail.com>
meln5674
force-pushed
the
feature/remote-tls
branch
from
71d2dbf to
5765e3e
Compare
Contributor
|
Cc: @ashley-cui , I’m not sure where the review conversations should be happening. |
Contributor
|
LGTM, waiting on the Podman PR to pass. |
Contributor
|
LGTM @containers/container-libs-maintainers PTAL and merge |
ashley-cui
reviewed
Sep 24, 2025
Contributor
ashley-cui
left a comment
ashley-cui
left a comment
There was a problem hiding this comment.
Last comment, apologies.
Comment on lines
+711
to
+715
| TLSCertFile string `json:",omitempty" toml:"tls_cert_file,omitempty"` | ||
| // Path to TLS client certificate private key PEM file, optional | ||
| TLSKeyFile string `json:",omitempty" toml:"tls_key_file,omitempty"` | ||
| // Path to TLS certificate authority PEM file, optional | ||
| TLSCAFile string `json:",omitempty" toml:"tls_ca_file,omitempty"` |
Contributor
There was a problem hiding this comment.
Sorry, one last nit, can we change these to just TLSCert TLSKey TLSCA? The file part seems redundant and changing them would match the flags in podman.
|
|
||
| Path to file containing ssh identity key | ||
|
|
||
| **tls_cert_file="/path/to/certs/podman/tls.crt"** |
Signed-off-by: Andrew Melnick <meln5674.5674@gmail.com>
meln5674
force-pushed
the
feature/remote-tls
branch
from
978af7b to
8e9b008
Compare
|
Packit jobs failed. @containers/packit-build please check. |
mtrmac
reviewed
Sep 25, 2025
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Merging based on @ashley-cui ’s approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional fields tls_cert_file, tls_key_file, and tls_cafile to the configuration TOML to support connecting to TLS and mTLS podman API sockets.
This is in support of podman-container-tools/podman#24601 to fix podman-container-tools/podman#24583 .
This PR is a carry-over from containers/common#2249