Skip to content

Fixing Webpart title render issue#6148

Merged
hugoabernier merged 3 commits intopnp:mainfrom
NishkalankBezawada:feat/update-reactControls-propertyControls
Apr 26, 2026
Merged

Fixing Webpart title render issue#6148
hugoabernier merged 3 commits intopnp:mainfrom
NishkalankBezawada:feat/update-reactControls-propertyControls

Conversation

@NishkalankBezawada
Copy link
Copy Markdown
Contributor

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This webpart was using older versions of spfx-controls-react and spfx-property-controls which was causing the issue of rendering the webpart title. The reason was that the older versions were not on SPFx v1.22.2.

Updating to the latest version resolved the issue (screenshot below.)

image

Node Version

(Use node -v to get the version of Node you used to build this sample)

Node version used: v22.15.1

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@github-actions
Copy link
Copy Markdown
Contributor

Sample PR validation for #6148

⚠️ Validation status: warnings

We automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community.

In order to merge this PR in a timely manner, the following criteria must be met:

Validation Status
Pull request affects only one folder ✅ Succeeded
Sample folder name follows naming convention ✅ Succeeded
README.md contains visitor stat image ✅ Succeeded
Sample requires a .nvmrc file ⚠️ Warning
Sample requires a README.md ✅ Succeeded
Sample requires a screenshot .png in assets folder ⚠️ Warning
No .sppkg file ✅ Succeeded
No node_modules folder ✅ Succeeded
No lib folder ✅ Succeeded
No upgrade reports ✅ Succeeded

@NishkalankBezawada please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.

@hugoabernier hugoabernier merged commit 902aba5 into pnp:main Apr 26, 2026
4 checks passed
@hugoabernier
Copy link
Copy Markdown
Collaborator

Thank you @Nishkalank Bezawada for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@github-actions
Copy link
Copy Markdown
Contributor

Sample PR validation for #6148

⚠️ Validation status: warnings

We automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community.

In order to merge this PR in a timely manner, the following criteria must be met:

Validation Status
Pull request affects only one folder ✅ Succeeded
Sample folder name follows naming convention ✅ Succeeded
README.md contains visitor stat image ✅ Succeeded
Sample requires a .nvmrc file ⚠️ Warning
Sample requires a README.md ✅ Succeeded
Sample requires a screenshot .png in assets folder ⚠️ Warning
No .sppkg file ✅ Succeeded
No node_modules folder ✅ Succeeded
No lib folder ✅ Succeeded
No upgrade reports ✅ Succeeded

@NishkalankBezawada please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants