Skip to content

fix(vanilla): remove Object.preventExtensions from createSnapshotDefault for Hermes compatibility #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dai-shi merged 2 commits into from
May 1, 2026
Merged

fix(vanilla): remove Object.preventExtensions from createSnapshotDefault for Hermes compatibility #1220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6e2780
fix(vanilla): remove immutability enforcement in snapshot
manakuro Apr 12, 2026
3510558
Apply suggestion from @dai-shi
dai-shi Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vanilla.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const createSnapshotDefault = <T extends object>(
}
Object.defineProperty(snap, key, desc)
})
return Object.preventExtensions(snap)
return snap
Comment thread
dai-shi marked this conversation as resolved.
}

const createHandlerDefault = <T extends object>(
Expand Down
20 changes: 0 additions & 20 deletions tests/snapshot.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,6 @@ describe('snapshot', () => {
expect(snap1).toBe(snap2)
})

it('should make the snapshot immutable', () => {
const state = proxy<{ foo: number; bar?: string }>({ foo: 1 })
const snap = snapshot(state)

// Overwriting existing property
expect(() => {
;(snap as typeof state).foo = 100
}).toThrow()

// Extension (adding new property)
expect(() => {
;(snap as typeof state).bar = 'hello'
}).toThrow()

// Note: The current implementation does not prevent property removal.
// Do not add a test for this unless we come up with an implementation that
// supports it.
// See https://github.com/pmndrs/valtio/issues/749
})

it('should not cause proxy-compare to copy', async () => {
const state = proxy({ foo: 1 })
const snap1 = snapshot(state)
Expand Down