-
-
Notifications
You must be signed in to change notification settings - Fork 283
test(ssr): add SSR and hydration tests for 'getServerSnapshot' #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sukvvon
wants to merge
4
commits into
pmndrs:main
Choose a base branch
from
sukvvon:test/basic-getServerSnapshot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f1ddb98
test(basic): add test for 'getServerSnapshot' with 'renderToString'
sukvvon 49104ce
test(ssr): move SSR test to separate 'ssr.test.tsx' file
sukvvon 3aea407
test(ssr): rename test description and add test for latest snapshot a…
sukvvon a5c4d42
test(ssr): add hydration mismatch test for 'getServerSnapshot' valida…
sukvvon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { StrictMode } from 'react' | ||
| import { act } from '@testing-library/react' | ||
| import { hydrateRoot } from 'react-dom/client' | ||
| import { renderToString } from 'react-dom/server' | ||
| import { afterEach, describe, expect, it, vi } from 'vitest' | ||
| import { proxy, useSnapshot } from 'valtio' | ||
|
|
||
| describe('ssr', () => { | ||
| afterEach(() => { | ||
| document.body.innerHTML = '' | ||
| }) | ||
|
|
||
| it('should return initial snapshot in SSR', () => { | ||
| const obj = proxy({ count: 0 }) | ||
|
|
||
| const Counter = () => { | ||
| const snap = useSnapshot(obj) | ||
| return <div>count: {snap.count}</div> | ||
| } | ||
|
|
||
| const view = renderToString( | ||
| <StrictMode> | ||
| <Counter /> | ||
| </StrictMode>, | ||
| ) | ||
|
|
||
| expect(view).toContain('count:') | ||
| expect(view).toContain('0') | ||
| }) | ||
|
|
||
| it('should return the latest snapshot after proxy state changes', () => { | ||
| const obj = proxy({ count: 0 }) | ||
|
|
||
| obj.count = 5 | ||
|
|
||
| const Counter = () => { | ||
| const snap = useSnapshot(obj) | ||
| return <div>count: {snap.count}</div> | ||
| } | ||
|
|
||
| const view = renderToString( | ||
| <StrictMode> | ||
| <Counter /> | ||
| </StrictMode>, | ||
| ) | ||
|
|
||
| expect(view).toContain('count:') | ||
| expect(view).toContain('5') | ||
| }) | ||
|
|
||
| it('should not cause hydration mismatch', async () => { | ||
| const obj = proxy({ count: 0 }) | ||
|
|
||
| const Counter = () => { | ||
| const snap = useSnapshot(obj) | ||
| return <div>count: {snap.count}</div> | ||
| } | ||
|
|
||
| const view = renderToString( | ||
| <StrictMode> | ||
| <Counter /> | ||
| </StrictMode>, | ||
| ) | ||
|
|
||
| const container = document.createElement('div') | ||
| container.innerHTML = view | ||
| document.body.appendChild(container) | ||
|
|
||
| const errorSpy = vi.spyOn(console, 'error') | ||
|
|
||
| await act(() => | ||
| hydrateRoot( | ||
| container, | ||
| <StrictMode> | ||
| <Counter /> | ||
| </StrictMode>, | ||
| ), | ||
| ) | ||
|
|
||
| expect(errorSpy).not.toHaveBeenCalled() | ||
|
|
||
| errorSpy.mockRestore() | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too naive. The AI doesn't understand the underlying problem.
Try to create a bug so that such a hydration-mismatch test fails.
I'm not sure if it's possible. But, otherwise, it's not valid for
getServerSnapshottest.