Skip to content

FIX / Handle group assignment on uninstall templates #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mary-Clb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIX / Handle group assignment on uninstall templates #199

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
276603f
fix: handle group assignment on uninstall templates
Mary-Clb Apr 8, 2026
f0ceec0
use AssignableItemInterface
Mary-Clb Apr 8, 2026
d1cc5a5
update CHANGELOG.md
Mary-Clb Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion inc/uninstall.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ private static function doOneUninstall(PluginUninstallModel $model, Transfer $tr
}
}

if ($item->isField('groups_id')) {
$can_update_groups = $item->isField('groups_id') || method_exists($item, 'prepareGroupFields');
if ($can_update_groups) {
Copy link
Copy Markdown
Contributor

@Rom1-B Rom1-B Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this?

Suggested change
$can_update_groups = $item->isField('groups_id') || method_exists($item, 'prepareGroupFields');
if ($can_update_groups) {
if (
$item->isField('groups_id') ||
($item instanceof AssignableItemInterface)
) {

Then have the customer validate the patch?

$nbgroup = countElementsInTableForEntity(
"glpi_groups",
$entity,
Expand Down