Open
Conversation
Top bar - Add consistent styling and spacing for all buttons in the top bar - Move period arrows into the period picker visually instead of displaying them as separate buttons - Add selected state to buttons; when dropdown is open, the trigger background is light gray. This is also true when comparison is enabled. - Change filter button icon from magnifying glass to a filter icon - Change period picker button icons from chevron on the right to calendar icons on the left - Make top bar scroll horizontally on mobile instead of clipping New options menu (⋮) - Move interval picker, export button, imported data toggle and notices out of the graph and into a new options menu in the top bar - Hide menu in realtime mode - Render button immediately as a non-interactive placeholder on page load to prevent layout shift - Change interval picker dropdown to a segmented control - Change the imported data toggle to an actual toggle button - Change notice icon + tooltip to an inline notice component Top stats - Change selected metric background highlight to a subtle background instead of a coloured underline on the label - Refine stat labels and values typography and colors - Ensure change arrows and percentages are shown also when in comparison mode (and removed from tooltip) - Show "until HH:MM" when "Today" is the comparison date range to indicate a partial day Code organisation - Introduce a shared React context (DashboardOptionsProvider) to pass graph state (intervals, import settings) up to the top bar without prop drilling - Move custom icons to a shared icons file - Extract segmented control, toggle button and notice as reusable components - Old standalone StatsExport, WithImportedSwitch, and NoticesIcon components removed; functionality consolidated into the options menu
d0eeb10 to
269eac4
Compare
07c0dc1 to
f334e4d
Compare
|
Contributor
|
Tested on preview. Feels great to me overall. A couple things I noticed while testing: 1. Date picker has uneven padding when arrows not shown
The padding looks good with arrows. 2. Date picker dropdown has some weirdness I cannot close the dropdown by clicking outside of it just above the datepicker: https://cap.so/s/8dg13mgn12zk6bb Also I cannot replicate this for some reason but once I did manage to get it into this state where the focus ring shows and does not look great
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Changes
Top bar
New options menu (⋮)
ikeyboard shortcut now cycles through graph intervals rather than opening the dropdown menu – also when the options menu is closedTop stats
Code organisation
Before and after:
https://github.com/user-attachments/assets/ec519314-629f-4034-87d9-9cded458f646
New options menu:

Tests
Changelog
Documentation
Dark mode