Skip to content

Fix footnote - #54

Open
chuxinyuan wants to merge 2 commits into
pku-typst:mainfrom
chuxinyuan:fix-footnote
Open

Fix footnote#54
chuxinyuan wants to merge 2 commits into
pku-typst:mainfrom
chuxinyuan:fix-footnote

Conversation

@chuxinyuan

@chuxinyuan chuxinyuan commented Aug 1, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Style
    • Improved footnote formatting with smaller superscripts, justified text, consistent spacing, and a hanging indent.
    • Footnotes now use the configured footnote size and matching line spacing.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b2d81d46-95e3-4f79-b8ee-dbdabcfdc723

📥 Commits

Reviewing files that changed from the base of the PR and between 15e783a and 8c179e4.

📒 Files selected for processing (1)
  • template.typ
🚧 Files skipped from review as they are similar to previous changes (1)
  • template.typ

📝 Walkthrough

Walkthrough

The template updates footnote superscripts and entries with smaller sizing, configured font settings, justified text, footnote leading, zero spacing, and a hanging indent.

Changes

Document formatting

Layer / File(s) Summary
Footnote typography
template.typ
Footnote superscripts use 0.65em sizing. Footnote entries use the configured Song font and size, justified paragraphs, footnote leading, zero spacing, and a 1.5em hanging indent.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: correcting footnote formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@template.typ`:
- Around line 181-186: Update the footnote paragraph rule’s set par
configuration to explicitly set first-line-indent to 0pt, preserving the
existing hanging-indent behavior for continuation lines.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bf0e90c5-3de8-46f6-bb43-0af607e63aaa

📥 Commits

Reviewing files that changed from the base of the PR and between 41d60fa and 845395d.

📒 Files selected for processing (2)
  • lib/components.typ
  • template.typ

Comment thread template.typ
@chuxinyuan chuxinyuan closed this Aug 1, 2026
@chuxinyuan chuxinyuan reopened this Aug 1, 2026
OS: Linux x64 7.1.5-arch1-2
Typst: 0.15.1
Description: By explicitly setting the footnote font and font size, the current problem of small footnote display has been resolved. But I'm not sure if "leading" needs to be changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant