Skip to content

pkp/pkp-lib#12534 Migrate reviewer step 3 form (review submission) from Smarty/jQuery to Vue #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blesildaramirez wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#12534 Migrate reviewer step 3 form (review submission) from Smarty/jQuery to Vue #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9099e1f
pkp/pkp-lib#12534 Update selectors when adding comments in review ste…
blesildaramirez Apr 14, 2026
9727716
pkp/pkp-lib#12534 Submodule updates
blesildaramirez Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress/tests/integration/CompetingInterests.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('Data suite tests', function() {
cy.get('button:contains("Accept Review, Continue to Step #2")').click();
cy.get('button:contains("Continue to Step #3")').click();
cy.wait(2000); // Give TinyMCE control time to load
cy.get('textarea[id^="comments-"]').then(node => {
cy.get('textarea#reviewStep3Form-comments-control').then(node => {
cy.setTinyMceContent(node.attr('id'), 'This paper is suitable for publication.');
});
cy.get('button:contains("Submit Review")').click();
Expand Down Expand Up @@ -86,7 +86,7 @@ describe('Data suite tests', function() {
cy.get('button:contains("Accept Review, Continue to Step #2")').click();
cy.get('button:contains("Continue to Step #3")').click();
cy.wait(2000); // Give TinyMCE control time to load
cy.get('textarea[id^="comments-"]').then(node => {
cy.get('textarea#reviewStep3Form-comments-control').then(node => {
cy.setTinyMceContent(node.attr('id'), 'This paper is suitable for publication.');
});
cy.get('button:contains("Submit Review")').click();
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 58 files
+113 −2 api/v1/submissions/PKPSubmissionFileController.php
+68 −0 classes/security/authorization/ReviewAssignmentFileAccessPolicy.php
+5 −5 classes/security/authorization/SubmissionFileAccessPolicy.php
+72 −24 classes/submission/reviewer/form/PKPReviewerReviewStep3Form.php
+3 −2 cypress/support/commands.js
+18 −4 js/load.js
+1 −0 locale/an/reviewer.po
+1 −0 locale/ar/reviewer.po
+1 −0 locale/az/reviewer.po
+1 −0 locale/bg/reviewer.po
+1 −0 locale/ca/reviewer.po
+1 −0 locale/ckb/reviewer.po
+1 −0 locale/cs/reviewer.po
+1 −0 locale/da/reviewer.po
+1 −0 locale/de/reviewer.po
+1 −0 locale/el/reviewer.po
+1 −1 locale/en/reviewer.po
+1 −0 locale/es/reviewer.po
+1 −0 locale/eu/reviewer.po
+1 −0 locale/fa/reviewer.po
+1 −0 locale/fi/reviewer.po
+1 −0 locale/fr/reviewer.po
+1 −0 locale/fr_CA/reviewer.po
+1 −0 locale/gl/reviewer.po
+1 −0 locale/hr/reviewer.po
+1 −0 locale/hu/reviewer.po
+1 −0 locale/hy/reviewer.po
+1 −0 locale/id/reviewer.po
+1 −0 locale/is/reviewer.po
+1 −0 locale/it/reviewer.po
+1 −0 locale/ja/reviewer.po
+1 −0 locale/ka/reviewer.po
+1 −0 locale/kk/reviewer.po
+1 −0 locale/ky/reviewer.po
+1 −0 locale/lt/reviewer.po
+1 −0 locale/lv/reviewer.po
+1 −0 locale/mk/reviewer.po
+1 −0 locale/mr/reviewer.po
+1 −0 locale/ms/reviewer.po
+1 −0 locale/nb_NO/reviewer.po
+1 −0 locale/nl/reviewer.po
+1 −0 locale/pl/reviewer.po
+1 −0 locale/pt/reviewer.po
+1 −0 locale/pt_BR/reviewer.po
+1 −0 locale/ro/reviewer.po
+1 −0 locale/ru/reviewer.po
+1 −0 locale/sl/reviewer.po
+1 −0 locale/sr_Cyrl/reviewer.po
+1 −0 locale/sr_Latn/reviewer.po
+1 −0 locale/sv/reviewer.po
+1 −0 locale/sw/reviewer.po
+1 −0 locale/th/reviewer.po
+1 −0 locale/tr/reviewer.po
+1 −0 locale/uk/reviewer.po
+1 −0 locale/vi/reviewer.po
+1 −0 locale/zh_Hant/reviewer.po
+16 −0 pages/reviewer/PKPReviewerHandler.php
+19 −79 templates/reviewer/review/step3.tpl
2 changes: 1 addition & 1 deletion lib/ui-library
Open in desktop
Submodule ui-library updated 12 files
+10 −0 public/globals.js
+4 −1 src/components/Container/Page.vue
+7 −0 src/components/Form/Form.vue
+22 −0 src/components/Form/FormPage.vue
+5 −1 src/composables/useForm.js
+1 −0 src/managers/FileManager/FileManager.vue
+11 −4 src/managers/FileManager/fileManagerStore.js
+33 −11 src/managers/FileManager/useFileManagerActions.js
+38 −0 src/managers/FileManager/useFileManagerConfig.js
+34 −0 src/pages/reviewerSubmission/forms/ReviewGuidelinesButton.vue
+62 −0 src/pages/reviewerSubmission/forms/ReviewerReviewStep3Form.vue
+385 −0 src/pages/reviewerSubmission/forms/useReviewerReviewStep3Form.js
Loading