Skip to content

pkp/pkp-lib#12617 Don't let crossref validation block publishing #5538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taslangraham wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −6
Open

pkp/pkp-lib#12617 Don't let crossref validation block publishing #5538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d5d338
pkp/pkp-lib#12617 Don't let crossref validation block publishing
taslangraham May 12, 2026
ebf8ef9
Submodule update
taslangraham May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions classes/components/forms/publication/PublishForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,35 @@ public function __construct($action, $publication, $submissionContext, $requirem

// Set separate messages and buttons if publication requirements have passed
if (empty($requirementErrors)) {
// Get any warnings that should be displayed when publishing.
$submission = Repo::submission()->get($publication->getData('submissionId'));
$warnings = Repo::publication()->validatePublishWarnings(
$publication,
$submission,
$submissionContext->getSupportedSubmissionLocales(),
$submissionContext->getPrimaryLocale()
);

if (!empty($warnings)) {
$msg = '<div class="pkpNotification"><b>' . __('publication.publish.warning') . '</b>';
$msg .= '<ul>';
foreach ($warnings as $error) {
$msg .= '<li>' . $error . '</li>';
}
$msg .= '</ul></div><br>';
}

$issue = $publication->getData('issueId')
? Repo::issue()->get($publication->getData('issueId'))
: null;
$msg = __('publication.publish.confirmation');
$msg .= __('publication.publish.confirmation');
$submitLabel = __('publication.publish');

// If the publication is marked as ready to publish,
// it will be published immediately regardless of the issue assignment
// or to a future issue, it will be published immediately
if ($publication->getData('status') == Publication::STATUS_READY_TO_PUBLISH) {
$msg = match($issue?->getData('published')) {
$msg .= match($issue?->getData('published')) {
true => __(
'publication.publish.confirmation.backIssue',
['issue' => htmlspecialchars($issue->getIssueIdentification())]
Expand All @@ -81,7 +99,7 @@ public function __construct($action, $publication, $submissionContext, $requirem
}

if ($publication->getData('status') == Publication::STATUS_READY_TO_SCHEDULE) {
$msg = __(
$msg .= __(
'publication.publish.confirmation.futureIssue',
['issue' => htmlspecialchars($issue->getIssueIdentification())]
);
Expand All @@ -92,7 +110,6 @@ public function __construct($action, $publication, $submissionContext, $requirem
$publicationVersion = $publication->getVersion();

if (!isset($publicationVersion)) {
$submission = Repo::submission()->get($publication->getData('submissionId'));
$nextVersion = Repo::submission()->getNextAvailableVersion($submission, Publication::DEFAULT_VERSION_STAGE, false);

$msg .= '<p>' . __('publication.required.versionStage') . '</p>';
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 4 files
+16 −0 classes/publication/Repository.php
+0 −1 controllers/modals/publish/PublishHandler.php
+3 −0 locale/en/submission.po
+1 −1 pages/orcid/OrcidHandler.php
2 changes: 1 addition & 1 deletion plugins/generic/crossref
Open in desktop
Submodule crossref updated 2 files
+4 −2 CrossrefCitationDoiHandler.php
+3 −3 CrossrefPlugin.php
Loading