pkp/pkp-lib#12584 Add "Summary of Changes/Amendment" field on file revision upload and update publication issues page#5525
pkp/pkp-lib#12584 Add "Summary of Changes/Amendment" field on file revision upload and update publication issues page#5525blesildaramirez wants to merge 11 commits into
Conversation
blesildaramirez
force-pushed
the
i12584
branch
3 times, most recently
from
39b73c0 to
1a49778
Compare
| "apiSummary": true | ||
| }, | ||
| "updateType": { | ||
| "type": "string", |
There was a problem hiding this comment.
Ok I see you are adding in here.. Since Bozana confirmed that Amendment make sense for all apps - I think both mibration and schema updates can go to pkp-lib. And we can just separately figure out where exactly to add it for OPS/OMP in the UI.
There was a problem hiding this comment.
Hi Jarda, I moved this change to pkp-lib as suggested offline. Thanks!
| 'value' => $updateType->value, | ||
| ]; | ||
| } | ||
| $pageInitConfig['componentForms']['updateTypeOptions'] = $updateTypeOptions; |
There was a problem hiding this comment.
I see we have this pattern already used for VersionStage. Lets think about some alternatives on wednesday. I would like to keep these data snippets being passed on page load to minimum as we are aiming for higher independency between frontend and backend. Will need to think about more about solid approach. But for this PR keep as is.
blesildaramirez
force-pushed
the
i12584
branch
3 times, most recently
from
b32a84c to
b1943e3
Compare
…ataForm component
|
/deploy |
2 participants
No description provided.