Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 89.18% 88.55% -0.64%
==========================================
Files 100 109 +9
Lines 12294 12699 +405
Branches 1624 1637 +13
==========================================
+ Hits 10964 11245 +281
- Misses 1277 1400 +123
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closing. This has been addressed by the Rust rewrite. |
@pionxzh Curious, does the rust rewrite actually use ast-grep directly at all? Or do you mean that the performance gains of the rust rewrite make this irrelevant now? Edit: GitHub Copilot seems to suggest that it's probably not included directly, based on the |
|
@0xdevalias Wording issue! 😄 The reason for this PR is to explore whether we could use I also looked into using |
@pionxzh Cool cool, that makes sense, and aligns with what I figured the direction probably was. Thanks for confirming :) |
|
Noting some random thoughts / notes here in case future me comes back to pondering them.
One case where I have many more thoughts and local notes on this sort of pattern, historical issues with it, a trace of how that has been improved over time, and various modern options; but I am still in the 'research' phase with it; I will post them somewhere more relevant once I am done.
While it may not directly support the SWC AST currently, as I noted above (ref: #111 (comment)), in May 2025'ish, they made it possible to implement different parser backends other than There was a PoC PR that showed what implementing That might be useful if it was found that There were also some experiments for using Where these latter comments seemed notable:
With regards to the comments about how the Asking GitHub Copilot (GPT-5.4) to explore that a bit:
|
|
Thanks. I'm planing to build a ast-grep like simpler internal module based on swc for wakaru. Will share again if it really works. I have talked with ast-grep author about this. |
@pionxzh Cool cool; sounds interesting :) Edit: Not sure if it would be useful for that / if you've already explored it / similar; but I also saw GritQL which sounds kind of interesting (though it's currently only implemented on
|
This PR introduces
ast-grepas a new rule provider. We can implement some one-to-one rules with ast-grep, which brings better performance.I'm not sure if this is a good move since the perf says JS is also fast on these one-to-one rules. The total execution time diff is not that obvious. I will have to do more tests with samples of different sizes.
Related: #35