Skip to content

perf: keep Slise banner mounted across navigation + gapless per-page … #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liangping merged 1 commit into from
Jul 9, 2026
Merged

perf: keep Slise banner mounted across navigation + gapless per-page … #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/ad/AdBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<!-- Ad container with required attributes -->
<div ref="containerRef" class="flex w-full justify-center overflow-hidden" :style="containerStyle">
<ins
ref="insRef"
class="adsbyslise"
:style="adStyle"
:data-ad-slot="slot"
Expand All @@ -12,7 +13,8 @@
</template>

<script setup lang="ts">
import { computed, onBeforeUnmount, onMounted, ref } from 'vue';
import { computed, onBeforeUnmount, onMounted, ref, watch } from 'vue';
import { useRoute } from 'vue-router';

declare global {
interface Window {
Expand Down Expand Up @@ -47,7 +49,9 @@ const props = defineProps({
});

const containerRef = ref<HTMLElement | null>(null);
const insRef = ref<HTMLElement | null>(null);
const scale = ref(1);
const route = useRoute();

function toPixels(value: string) {
const parsed = Number.parseFloat(value);
Expand Down Expand Up @@ -102,6 +106,12 @@ onMounted(() => {
}
});

watch(() => route.fullPath, () => {
if (!insRef.value || typeof window.adsbyslisesync !== 'function') return;
insRef.value.removeAttribute('data-ad-loaded');
window.adsbyslisesync();
});

onBeforeUnmount(() => {
observer?.disconnect();
});
Expand Down
6 changes: 2 additions & 4 deletions src/layouts/components/DefaultLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,10 @@ const show_ad = computed(() => {
>
</div>
</div>
<AdBanner v-if="show_ad" />
<RouterView v-slot="{ Component }">
<Transition mode="out-in">
<div>
<AdBanner v-if="show_ad" />
<Component :is="Component" />
</div>
<Component :is="Component" />
</Transition>
</RouterView>
</div>
Expand Down
Loading